Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(volume): add remount read only volume grpc #392

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

ChanYiLin
Copy link
Contributor

@ChanYiLin ChanYiLin commented Feb 7, 2024

ref: longhorn/longhorn#7843

Provide a grpc function to remount the volume global mount path to read write

pkg/types/types.go Outdated Show resolved Hide resolved
pkg/proxy/volume.go Outdated Show resolved Hide resolved
@ChanYiLin ChanYiLin force-pushed the LH7843_remount_read_only_volume branch 2 times, most recently from 38621fd to 2cbdc2a Compare February 7, 2024 14:32
@ChanYiLin ChanYiLin force-pushed the LH7843_remount_read_only_volume branch 2 times, most recently from 1873ea4 to bc60f2a Compare February 19, 2024 04:41
shuo-wu
shuo-wu previously approved these changes Feb 19, 2024
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one request.

proto/vendor/protobuf/src/google/protobuf/empty.proto Outdated Show resolved Hide resolved
ref: longhorn/longhorn 7843

Signed-off-by: Jack Lin <jack.lin@suse.com>
@innobead innobead merged commit 677fbd9 into longhorn:master Feb 19, 2024
6 checks passed
@ChanYiLin
Copy link
Contributor Author

@mergify backport v1.6.1

@ChanYiLin
Copy link
Contributor Author

@mergify backport v1.6.x

Copy link

mergify bot commented Feb 19, 2024

backport v1.6.1

❌ No backport have been created

  • Backport to branch v1.6.1 failed

GitHub error: Branch not found

Copy link

mergify bot commented Feb 19, 2024

backport v1.6.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants