Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting spdk_tgt log level and flags #402

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Support setting spdk_tgt log level and flags #402

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b15a905
vendor: update dependencies
derekbit Feb 23, 2024
f674ea1
Dockerfile: build spdk with "--enable-debug" option
derekbit Feb 16, 2024
08e60f3
Dockerfile: update go-spdk-helper
derekbit Feb 17, 2024
6b6c387
proto: add log get and set methods
derekbit Feb 17, 2024
10fb410
instance: implement log client and server functions
derekbit Feb 20, 2024
53e6ffe
Bump InstanceManagerAPIVersion to 6
derekbit Feb 20, 2024
375d790
Update arguments of namspaced Execute()
derekbit Feb 23, 2024
0d2f299
Merge branch 'master' into issue-7939
innobead Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/proxy/volume.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ func (p *Proxy) RemountReadOnlyVolume(ctx context.Context, req *rpc.RemountVolum
"remount,rw",
mp.Path,
}
if _, err := nsexec.Execute("mount", opts, lhtypes.ExecuteDefaultTimeout); err != nil {
if _, err := nsexec.Execute(nil, "mount", opts, lhtypes.ExecuteDefaultTimeout); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChanYiLin @derekbit already fixed the issue here.

return nil, grpcstatus.Errorf(grpccodes.Internal, "remount failed with error: %v", err)
}
}
Expand Down