Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add longhorn/types #404

Merged
merged 3 commits into from
Apr 18, 2024
Merged

feat: add longhorn/types #404

merged 3 commits into from
Apr 18, 2024

Conversation

FrankYang0529
Copy link
Contributor

@FrankYang0529 FrankYang0529 commented Feb 21, 2024

Which issue(s) this PR fixes:

Issue longhorn/longhorn#6744, longhorn/longhorn#5752

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@FrankYang0529 FrankYang0529 requested a review from a team as a code owner February 21, 2024 02:43
@FrankYang0529 FrankYang0529 marked this pull request as draft February 21, 2024 02:43
Copy link

mergify bot commented Feb 22, 2024

This pull request is now in conflict. Could you fix it @FrankYang0529? 🙏

Copy link

mergify bot commented Apr 15, 2024

This pull request is now in conflict. Could you fix it @FrankYang0529? 🙏

Signed-off-by: PoAn Yang <poan.yang@suse.com>
derekbit
derekbit previously approved these changes Apr 18, 2024
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrankYang0529 ready to merge?

@FrankYang0529
Copy link
Contributor Author

LGTM

@FrankYang0529 ready to merge?

Hi @derekbit, may we merge longhorn/longhorn-engine#1015 first? So I can remove replace in go.mod. Thanks.

@derekbit
Copy link
Member

LGTM
@FrankYang0529 ready to merge?

Hi @derekbit, may we merge longhorn/longhorn-engine#1015 first? So I can remove replace in go.mod. Thanks.

Sure! Merged.

Signed-off-by: PoAn Yang <poan.yang@suse.com>
Signed-off-by: PoAn Yang <poan.yang@suse.com>
@FrankYang0529
Copy link
Contributor Author

Hi @derekbit, this one is ready. Thank you.

@derekbit
Copy link
Member

@FrankYang0529 Do you know who uses the gernerated python codes?

@FrankYang0529
Copy link
Contributor Author

@FrankYang0529 Do you know who uses the gernerated python codes?

longhorn-engine integration test uses it. I moved related files to longhorn-engine folder, so we don't need to copy it from longhorn-instance-manager.

https://github.com/longhorn/longhorn-engine/tree/master/integration

@derekbit
Copy link
Member

derekbit commented Apr 18, 2024

@FrankYang0529 Do you know who uses the gernerated python codes?

longhorn-engine integration test uses it. I moved related files to longhorn-engine folder, so we don't need to copy it from longhorn-instance-manager.

https://github.com/longhorn/longhorn-engine/tree/master/integration

Got it. Thank you.
Does it mean we need to manually update longhorn-engine/integration (not just go mod tidy/vendor) if proto files are updated and regenerated?

@FrankYang0529
Copy link
Contributor Author

@FrankYang0529 Do you know who uses the gernerated python codes?

longhorn-engine integration test uses it. I moved related files to longhorn-engine folder, so we don't need to copy it from longhorn-instance-manager.
https://github.com/longhorn/longhorn-engine/tree/master/integration

Got it. Thank you. Does it mean we need to manually update both longhorn-engine/integration if proto files are updated and regenerated?

We have a script working for it.

https://github.com/longhorn/longhorn-engine/blob/master/scripts/sync-grpc-py

@derekbit
Copy link
Member

@FrankYang0529 Do you know who uses the gernerated python codes?

longhorn-engine integration test uses it. I moved related files to longhorn-engine folder, so we don't need to copy it from longhorn-instance-manager.
https://github.com/longhorn/longhorn-engine/tree/master/integration

Got it. Thank you. Does it mean we need to manually update both longhorn-engine/integration if proto files are updated and regenerated?

We have a script working for it.

https://github.com/longhorn/longhorn-engine/blob/master/scripts/sync-grpc-py

Cool. I missed the python script.
Can you add the usage and the update flow in the WIKI page I mentioned yesterday?
Thank you.

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 74c78b7 into longhorn:master Apr 18, 2024
6 checks passed
@FrankYang0529 FrankYang0529 deleted the LH-6744 branch April 18, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants