Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): support v2 volume upgrade #474

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

derekbit
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#6001

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@derekbit derekbit self-assigned this Apr 20, 2024
Copy link

mergify bot commented Apr 23, 2024

This pull request is now in conflict. Could you fix it @derekbit? 🙏

@derekbit derekbit force-pushed the v2-volume-upgrade branch 2 times, most recently from 036f56e to 438cb36 Compare April 26, 2024 15:28
Copy link

mergify bot commented Apr 27, 2024

This pull request is now in conflict. Could you fix it @derekbit? 🙏

Copy link

mergify bot commented Apr 27, 2024

This pull request is now in conflict. Could you fix it @derekbit? 🙏

@derekbit derekbit force-pushed the v2-volume-upgrade branch 6 times, most recently from d7b98cc to dd3bebd Compare May 22, 2024 15:47
Copy link

mergify bot commented May 23, 2024

This pull request is now in conflict. Could you fix it @derekbit? 🙏

@derekbit derekbit force-pushed the v2-volume-upgrade branch 7 times, most recently from bc19699 to 449ed8a Compare June 4, 2024 09:05
@derekbit derekbit force-pushed the v2-volume-upgrade branch 2 times, most recently from 3cedcf0 to 614e25d Compare June 6, 2024 09:09
@derekbit derekbit force-pushed the v2-volume-upgrade branch 7 times, most recently from 492521d to ec11331 Compare June 18, 2024 08:10
Copy link

mergify bot commented Jul 5, 2024

This pull request is now in conflict. Could you fix it @derekbit? 🙏

@derekbit derekbit force-pushed the v2-volume-upgrade branch 2 times, most recently from 7786589 to c1539ac Compare July 7, 2024 07:42
Copy link

mergify bot commented Jul 7, 2024

This pull request is now in conflict. Could you fix it @derekbit? 🙏

Longhorn 6001

Signed-off-by: Derek Su <derek.su@suse.com>
@derekbit derekbit force-pushed the v2-volume-upgrade branch 3 times, most recently from ec24885 to 163a150 Compare July 8, 2024 16:42
@derekbit
Copy link
Member Author

derekbit commented Jul 8, 2024

@DamiaSan @shuo-wu Can you help review the PR? Thank you.

cc @innobead

@derekbit derekbit requested a review from c3y1huang July 9, 2024 03:14
pkg/client/instance.go Outdated Show resolved Hide resolved
@DamiaSan DamiaSan self-requested a review July 9, 2024 06:25
DamiaSan
DamiaSan previously approved these changes Jul 9, 2024
DamiaSan
DamiaSan previously approved these changes Jul 9, 2024
pkg/instance/instance.go Outdated Show resolved Hide resolved
pkg/instance/instance.go Outdated Show resolved Hide resolved
1. Update instance and spdk gRPC servers and clients
2. Support v2 volume live upgrade apis
  - InstanceSwitchOverTarget
  - InstanceResume
  - InstanceSuspend
  - InstanceDeleteTarget
3. Record targetPortStart and targetPortEnd in instance status

Longhorn 6001

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 6001

Signed-off-by: Derek Su <derek.su@suse.com>
Copy link
Contributor

@c3y1huang c3y1huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be beneficial to separate the (ops V1DataEngineInstanceOps) and (ops V2DataEngineInstanceOps) methods into different files? Maybe something to consider for future refactoring.

@derekbit
Copy link
Member Author

derekbit commented Jul 9, 2024

Do you think it would be beneficial to separate the (ops V1DataEngineInstanceOps) and (ops V2DataEngineInstanceOps) into different files? Maybe something to consider for future refactoring.

Yes, same thought. I will improve it after v1.7.0.

@derekbit derekbit merged commit 66c8c23 into longhorn:master Jul 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants