-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(upgrade): support v2 volume upgrade #474
Conversation
This pull request is now in conflict. Could you fix it @derekbit? 🙏 |
036f56e
to
438cb36
Compare
This pull request is now in conflict. Could you fix it @derekbit? 🙏 |
438cb36
to
174afad
Compare
This pull request is now in conflict. Could you fix it @derekbit? 🙏 |
d7b98cc
to
dd3bebd
Compare
This pull request is now in conflict. Could you fix it @derekbit? 🙏 |
bc19699
to
449ed8a
Compare
3cedcf0
to
614e25d
Compare
492521d
to
ec11331
Compare
db7381a
to
211a79b
Compare
This pull request is now in conflict. Could you fix it @derekbit? 🙏 |
7786589
to
c1539ac
Compare
This pull request is now in conflict. Could you fix it @derekbit? 🙏 |
c1539ac
to
15a9208
Compare
Longhorn 6001 Signed-off-by: Derek Su <derek.su@suse.com>
ec24885
to
163a150
Compare
163a150
to
fac2d54
Compare
1. Update instance and spdk gRPC servers and clients 2. Support v2 volume live upgrade apis - InstanceSwitchOverTarget - InstanceResume - InstanceSuspend - InstanceDeleteTarget 3. Record targetPortStart and targetPortEnd in instance status Longhorn 6001 Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 6001 Signed-off-by: Derek Su <derek.su@suse.com>
fac2d54
to
1d9a320
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would be beneficial to separate the (ops V1DataEngineInstanceOps)
and (ops V2DataEngineInstanceOps)
methods into different files? Maybe something to consider for future refactoring.
Yes, same thought. I will improve it after v1.7.0. |
Which issue(s) this PR fixes:
Issue longhorn/longhorn#6001
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context