feat(bitmap): use enhanced bitmap from go-common-libs #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is now in conflict. Could you fix it @james-munson? 🙏 |
|
The big part of this PR is switch from local bitmap to an enhanced one to be added to go-common-libs in longhorn/go-common-libs#60 Marking it as |
james-munson
force-pushed
the
7802-port-collision
branch
from
5bb27b6
to
8d297b9
Compare
james-munson
changed the title
Signed-off-by: James Munson <james.munson@suse.com>
james-munson
force-pushed
the
7802-port-collision
branch
from
8d297b9
to
af969cf
Compare
DamiaSan
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Just a little remainder for us all: in this repo the packages from go-common-libs are imported as lh, meanwhile in longhorn-spdk-engine they are imported as common. For example we have lhBitmap and commonBitmap for the same package, maybe in the future we could align them.
derekbit
approved these changes
Aug 21, 2024
|
@mergify backport v1.7.x |
✅ Backports have been created
|
|
I would like to see this fix backported to 1.7.2, so I have set a PR up for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#7802
What this PR does / why we need it:
Switch to use the enhanced bitmap utility to avoid immediate reuse and port collision.
Special notes for your reviewer:
Additional documentation or context