Skip to content

fix: failed to cancel volume expansion after engine is already expanded successfully #431

fix: failed to cancel volume expansion after engine is already expanded successfully

fix: failed to cancel volume expansion after engine is already expanded successfully #431

Triggered via pull request September 16, 2024 06:06
@derekbitderekbit
synchronize #3165
Status Failure
Total duration 23s
Artifacts

conventional_commits.yml

on: pull_request_target
commit-lint
14s
commit-lint
Fit to window
Zoom out
Zoom in

Annotations

1 error
commit-lint
You have commit messages with errors ⧗ input: fix: allow cancellation of volume expansion when e.Status.CurrentSize is not equal to v.Spec.Size and e.Spec.VolumeSize When the volume has already been successfully expanded, if the cancellation is issued after completing the volume expansion, and the spec.size and status.currentSize of the volume and engine are as follows: - v.spec.size: 21474836480 - e.spec.size: 21474836480 - e.status.currentSize: 22548578304 The check ``` if e.Spec.VolumeSize == v.Spec.Size { return nil } ``` prevents v.Status.ExpansionRequired from becoming true, which hinders the cancellation of the expansion. Longhorn 9466 Signed-off-by: Derek Su <derek.su@suse.com> ✖ header must not be longer than 100 characters, current length is 119 [header-max-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint