fix(backingimage): set default min number of copies when upgrading

ref: longhorn/longhorn 9352 Signed-off-by: Jack Lin <jack.lin@suse.com>
longhorn · Aug 30, 2024 · 68a4591 · 68a4591
1 parent c7c0d2f
commit 68a4591
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/types/setting.go b/types/setting.go
@@ -31,6 +31,8 @@ const (
 
 	// From `maximumChainLength` in longhorn-engine/pkg/replica/replica.go
 	MaxSnapshotNum = 250
+
+	DefaultMinNumberOfCopies = 3
 )
 
 type SettingType string
@@ -1463,7 +1465,7 @@ var (
 		Type:        SettingTypeInt,
 		Required:    true,
 		ReadOnly:    false,
-		Default:     "3",
+		Default:     strconv.Itoa(DefaultMinNumberOfCopies),
 		ValueIntRange: map[string]int{
 			ValueIntRangeMinimum: 1,
 		},

diff --git a/upgrade/v16xto170/upgrade.go b/upgrade/v16xto170/upgrade.go
@@ -9,6 +9,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	clientset "k8s.io/client-go/kubernetes"
 
+	"github.com/longhorn/longhorn-manager/types"
 	"github.com/longhorn/longhorn-manager/util"
 
 	longhorn "github.com/longhorn/longhorn-manager/k8s/pkg/apis/longhorn/v1beta2"
@@ -131,6 +132,8 @@ func upgradeBackingImages(namespace string, lhClient *lhclientset.Clientset, res
 				delete(bi.Spec.Disks, diskUUID)
 			}
 		}
+		// set the default value for bi.Spec.MinNumberOfCopies
+		bi.Spec.MinNumberOfCopies = types.DefaultMinNumberOfCopies
 	}
 
 	return nil