feat(controller): do not create any instance manager pods for v2 volu…

…mes if one is already existing

An extra instance manager pod for v2 data engine requires an additional CPU core and 2 GiB of memory.
If the resources are insufficient, the instance manager pod will be recreated and retried.
To minimize unnecessary retries, do not create any new instance manager pods if one is already running.

Longhorn 8456

Signed-off-by: Derek Su <derek.su@suse.com>

controller/instance_manager_controller.go

@@ -338,6 +338,19 @@ func (imc *InstanceManagerController) syncInstanceManager(key string) (err error
 		return err
 	}
 
+	// An instance manager pod for v2 volume need to consume huge pages, and disks managed by the
+	// pod is unable to managed by another pod. Therefore, if an instance manager pod is running on a node,
+	// an extra instance manager pod for v2 volume should not be created.
+	if types.IsDataEngineV2(im.Spec.DataEngine) {
+		syncable, err := imc.canProceedWithInstanceManagerSync(im)
+		if err != nil {
+			return err
+		}
+		if !syncable {
+			return nil
+		}
+	}
+
 	if err := imc.syncStatusWithNode(im); err != nil {
 		return err
 	}
@@ -365,6 +378,36 @@ func (imc *InstanceManagerController) syncInstanceManager(key string) (err error
 	return nil
 }
 
+func (imc *InstanceManagerController) canProceedWithInstanceManagerSync(currentIm *longhorn.InstanceManager) (bool, error) {
+	// If the instance manager is not stopped, proceed with the sync.
+	if currentIm.Status.CurrentState != longhorn.InstanceManagerStateStopped {
+		return true, nil
+	}
+
+	ims, err := imc.ds.ListInstanceManagersByNodeRO(currentIm.Spec.NodeID, longhorn.InstanceManagerTypeAllInOne, longhorn.DataEngineTypeV2)
+	if err != nil {
+		return false, err
+	}
+	// If there is another non-stopped instance manager pod for v2 volume, do not proceed with the sync.
+	for _, im := range ims {
+		if im.Name == currentIm.Name {
+			continue
+		}
+
+		if im.Status.CurrentState != longhorn.InstanceManagerStateStopped {
+			return false, nil
+		}
+	}
+
+	defaultInstanceManagerImage, err := imc.ds.GetSettingValueExisted(types.SettingNameDefaultInstanceManagerImage)
+	if err != nil {
+		return false, err
+	}
+
+	// Only active the sync when the default instance manager image is used.
+	return currentIm.Spec.Image == defaultInstanceManagerImage, nil
+}
+
 // syncStatusWithPod updates the InstanceManager based on the pod current phase only,
 // regardless of the InstanceManager previous status.
 func (imc *InstanceManagerController) syncStatusWithPod(im *longhorn.InstanceManager) error {