Skip to content

Commit

Permalink
fix(live upgrade): newly live upgraded engine doesn't respect the
Browse files Browse the repository at this point in the history
disableRevCounter setting

We forget to set disableRevCounter for the newly live upgraded engine.
As a result, the newly live upgraded engine always has disableRevCounter
as `false` even if the volume has disableRevCounter as `true`.

This mismatch prevents the volume from successfully rebuilding a new
replica.

longhorn-9331

Signed-off-by: Phan Le <phan.le@suse.com>
  • Loading branch information
PhanLe1010 authored and derekbit committed Aug 28, 2024
1 parent c99b453 commit abb8f26
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions engineapi/instance_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -728,6 +728,10 @@ func (c *InstanceManagerClient) engineInstanceUpgrade(req *EngineInstanceUpgrade
args = append(args, "--replica", GetBackendReplicaURL(addr))
}

if req.Engine.Spec.RevisionCounterDisabled {
args = append(args, "--disableRevCounter")
}

if req.EngineCLIAPIVersion >= 6 {
args = append(args,
"--size", strconv.FormatInt(req.Engine.Spec.VolumeSize, 10),
Expand Down

0 comments on commit abb8f26

Please sign in to comment.