fix(unit): modify unit tests for backup targets

Add more parameters in creating BackupVolume for testing volume_controller.go Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
longhorn · Nov 23, 2023 · ba8df4a · ba8df4a
1 parent 22cef5a
commit ba8df4a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/controller/controller_test.go b/controller/controller_test.go
@@ -89,6 +89,7 @@ const (
 	TestDeploymentName = "test-deployment"
 
 	TestBackupTarget     = "s3://backupbucket@us-east-1/backupstore"
+	TestBackupTargetName = "default"
 	TestBackupVolumeName = "test-backup-volume-for-restoration"
 	TestBackupName       = "test-backup-for-restoration"
 

diff --git a/controller/volume_controller_test.go b/controller/volume_controller_test.go
@@ -1318,10 +1318,19 @@ func (s *TestSuite) runTestCases(c *C, testCases map[string]*VolumeTestCase) {
 
 			backupVolume := &longhorn.BackupVolume{
 				ObjectMeta: metav1.ObjectMeta{
-					Name: bvName,
+					Name: bvName + "-" + TestBackupTargetName,
 					Finalizers: []string{
 						longhorn.SchemeGroupVersion.Group,
 					},
+					Labels: map[string]string{
+						types.LonghornLabelBackupTarget: TestBackupTargetName,
+						types.LonghornLabelBackupVolume: bvName,
+					},
+				},
+				Spec: longhorn.BackupVolumeSpec{
+					BackupTargetName: TestBackupTargetName,
+					BackupTargetURL:  TestBackupTarget,
+					VolumeName:       bvName,
 				},
 				Status: longhorn.BackupVolumeStatus{
 					LastBackupName: bName,