Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix migration stuck due to snapshot chains in old engine and new engine mismatch #2035

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Fix migration stuck due to snapshot chains in old engine and new engine mismatch #2035

merged 2 commits into from
Jun 29, 2023

Conversation

PhanLe1010
Copy link
Contributor

@PhanLe1010 PhanLe1010 commented Jun 28, 2023 •
edited
Loading

@PhanLe1010
Fix migration stuck due to snapshot chains in old engine and new engi…
0301b14 
…ne mismatch

Longhorn-6215

Signed-off-by: Phan Le <phan.le@suse.com>
@PhanLe1010 PhanLe1010 requested a review from a team as a code owner June 28, 2023 23:09
@PhanLe1010
Copy link
Contributor Author

PhanLe1010 commented Jun 28, 2023 •
edited
Loading

This set of tests passed 20 times after the PR:

for i in $(seq 1 20); do echo "Loop iteration: $i"; pytest -svvl test_migration.py::test_migration_with_failed_replica test_migration.py::test_migration_with_unscheduled_replica test_migration.py::test_migration_confirm test_migration.py::test_migration_rollback; done

They failed 20-25% of the time before the PR

@PhanLe1010 PhanLe1010 mentioned this pull request Jun 28, 2023
Closed
@innobead innobead self-requested a review June 29, 2023 04:59
innobead
innobead approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@innobead
Copy link
Member

@mergify backport v1.5.x

@PhanLe1010
Copy link
Contributor Author

Cc @mantissahz for reviewing

@innobead innobead merged commit 9bc7e07 into longhorn:master Jun 29, 2023
3 checks passed
@innobead
Copy link
Member

@mergify backport v1.5.x

@longhorn longhorn deleted a comment from mergify bot Jun 29, 2023
@PhanLe1010 PhanLe1010 mentioned this pull request Jun 29, 2023
Merged
@mergify
Copy link

mergify bot commented Jun 29, 2023 •
edited
Loading

backport v1.5.x

✅ Backports have been created

  • Backport to branch v1.5.x not needed, change already in branch v1.5.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

@derekbit derekbit derekbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhanLe1010 @innobead @derekbit