Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csi): Invalid mount point with volume detached (backport #2043) #2051

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 6, 2023

This is an automatic backport of pull request #2043 done by Mergify.
Cherry-pick of a9d6289 has failed:

On branch mergify/bp/v1.4.x/pr-2043
Your branch is up to date with 'origin/v1.4.x'.

You are currently cherry-picking commit a9d62894.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   csi/node_server.go
	both modified:   csi/util.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mantissahz
Copy link
Contributor

ref: longhorn/longhorn#5847

Volume detached because only one replica failed and not remount the
`globalmount`. We need to handle it at NodePublishVolume because
os.ReadDir will be passed when it becomes a read-only file system
after an unexpected volume detaching.

Use an empty file to test the file system

Ref: 4814, 5801

Signed-off-by: James Lu <james.lu@suse.com>
(cherry picked from commit a9d6289)
@innobead innobead merged commit 89d157f into v1.4.x Jul 6, 2023
4 checks passed
@innobead innobead deleted the mergify/bp/v1.4.x/pr-2043 branch July 6, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants