Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move some debug level messages to info level #2059

Merged
merged 3 commits into from
Jul 16, 2023
Merged

chore: move some debug level messages to info level #2059

merged 3 commits into from
Jul 16, 2023

Conversation

derekbit
Copy link
Member

No description provided.

@derekbit derekbit requested a review from a team as a code owner July 10, 2023 01:58
@derekbit derekbit self-assigned this Jul 10, 2023
@derekbit derekbit requested a review from c3y1huang July 10, 2023 02:21
@derekbit derekbit mentioned this pull request Jul 10, 2023
Merged
c3y1huang
c3y1huang requested changes Jul 10, 2023
View reviewed changes
controller/monitor/snapshot_monitor.go Outdated Show resolved Hide resolved
datastore/longhorn.go Outdated Show resolved Hide resolved
datastore/longhorn.go Outdated Show resolved Hide resolved
upgrade/upgrade.go Outdated Show resolved Hide resolved
upgrade/upgrade.go Outdated Show resolved Hide resolved
@derekbit derekbit force-pushed the log-message branch 3 times, most recently from bb7b691 to 6687209 Compare July 10, 2023 02:57
@derekbit derekbit requested a review from c3y1huang July 10, 2023 02:57
c3y1huang
c3y1huang previously approved these changes Jul 10, 2023
View reviewed changes
@derekbit
Copy link
Member Author

@mergify backport v1.5.x

@mergify
Copy link

mergify bot commented Jul 10, 2023

backport v1.5.x

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@derekbit derekbit mentioned this pull request Jul 10, 2023
Merged
@ChanYiLin
Copy link
Contributor

LGTM!

ChanYiLin
ChanYiLin previously approved these changes Jul 10, 2023
View reviewed changes
@innobead
Copy link
Member

@shuo-wu have any concerns?

@derekbit
Copy link
Member Author

cc @shuo-wu

@innobead
Copy link
Member

innobead commented Jul 16, 2023 •
edited
Loading

This improvement is for longhorn/longhorn#6257, so we should make the reference here.

innobead
innobead requested changes Jul 16, 2023
View reviewed changes
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM. Thanks, Derek. This is good indeed.

Just some feedbacks need to resolve first.

api/stream.go Outdated Show resolved Hide resolved
controller/engine_controller.go Show resolved Hide resolved
controller/setting_controller.go Outdated Show resolved Hide resolved
controller/system_rollout_controller.go Outdated Show resolved Hide resolved
controller/system_rollout_controller.go Outdated Show resolved Hide resolved
controller/volume_controller.go Show resolved Hide resolved
@derekbit
Move some debug level messages to info level
78bf22e 
Signed-off-by: Derek Su <derek.su@suse.com>
@derekbit
Update description of setting log-level
91a8a86 
Signed-off-by: Derek Su <derek.su@suse.com>
@derekbit derekbit requested a review from innobead July 16, 2023 12:05
@innobead
Copy link
Member

@mergify backport v1.5.x

@mergify
Copy link

mergify bot commented Jul 16, 2023 •
edited
Loading

backport v1.5.x

✅ Backports have been created

@innobead innobead merged commit 8f12052 into longhorn:master Jul 16, 2023
3 checks passed
@mergify mergify bot mentioned this pull request Jul 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

@ChanYiLin ChanYiLin ChanYiLin left review comments

@c3y1huang c3y1huang c3y1huang left review comments

Assignees

@derekbit derekbit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derekbit @ChanYiLin @innobead @c3y1huang