Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(support-bundle): download timed out #2066

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix(support-bundle): download timed out #2066

merged 1 commit into from
Jul 11, 2023

Conversation

c3y1huang
Copy link
Contributor

@c3y1huang c3y1huang self-assigned this Jul 10, 2023
@c3y1huang c3y1huang force-pushed the fix-support-bundle-download-timeout branch from 654766f to 5bfb8f5 Compare July 10, 2023 07:49
derekbit
derekbit approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c3y1huang
fix(support-bundle): download timed out
9aa08e6 
ref: 6256

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the fix-support-bundle-download-timeout branch from 5bfb8f5 to 9aa08e6 Compare July 11, 2023 05:13
@c3y1huang
Copy link
Contributor Author

Test results

@c3y1huang c3y1huang marked this pull request as ready for review July 11, 2023 05:13
@c3y1huang c3y1huang requested a review from a team as a code owner July 11, 2023 05:13
@c3y1huang c3y1huang mentioned this pull request Jul 11, 2023
Closed
innobead
innobead approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@innobead innobead left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

note: probably we don't need any client timeout but let the server side decide instead. @c3y1huang any concerns could be?

@innobead innobead merged commit ccd642b into longhorn:master Jul 11, 2023
3 checks passed
@innobead
Copy link
Member

@mergify backport v1.5.x v1.4.x

@mergify
Copy link

mergify bot commented Jul 11, 2023 •
edited
Loading

backport v1.5.x v1.4.x

✅ Backports have been created

This was referenced Jul 11, 2023
Merged
Merged
@c3y1huang c3y1huang deleted the fix-support-bundle-download-timeout branch July 11, 2023 06:50
@c3y1huang c3y1huang mentioned this pull request Jul 11, 2023
Merged
@WebberHuang1118 WebberHuang1118 mentioned this pull request Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

@derekbit derekbit derekbit approved these changes

Assignees

@c3y1huang c3y1huang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c3y1huang @innobead @derekbit