-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider a node with a failed reusable replica as still used (backport #2650) #2679
Conversation
Cherry-pick of 29a895c has failed:
Cherry-pick of 65ceb37 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
7d306bd
to
52aa894
Compare
I had to change this somewhat significantly since https://ci.longhorn.io/job/private/job/longhorn-tests-regression/6603/ |
52aa894
to
cf8f2c9
Compare
Actual test run (the previous was set up incorrectly): https://ci.longhorn.io/job/private/job/longhorn-tests-regression/6614/testReport/ |
The backport to v1.5.x was complex. It required some test refactoring that had not previously been backported. This commit includes the necessary refactor and the reworked Longhorn 8043 commits. Longhorn 8043 Signed-off-by: Eric Weber <eric.weber@suse.com> (cherry picked from commit 29a895c) (cherry picked from commit 65ceb37) (cherry picked from commit e685946)
cf8f2c9
to
8417a73
Compare
This is an automatic backport of pull request #2650 done by Mergify.
Cherry-pick of 29a895c has failed:
Cherry-pick of 65ceb37 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com