chore(vendor): update go-common-libs/go-iscsi-helper and resolve breaking changes #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on PRs:
|
ChanYiLin
force-pushed
the
LH7960_update_dependencies_and_resolve_breaking_changes
branch
from
058ffa9
to
7a8e1ec
Compare
|
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
ChanYiLin
force-pushed
the
LH7960_update_dependencies_and_resolve_breaking_changes
branch
from
7a8e1ec
to
b619732
Compare
…ing changes ref: longhorn/longhorn 7960 Signed-off-by: Jack Lin <jack.lin@suse.com>
ChanYiLin
force-pushed
the
LH7960_update_dependencies_and_resolve_breaking_changes
branch
from
b619732
to
7e3fc8f
Compare
Fixed. |
Sounds good. |
innobead
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#7960
Update dependencis and resolve the breaking changes.
The PR is mainly based on this PR https://github.com/longhorn/longhorn-manager/pull/2103/files
Talos support is not backported to v1.5.x. But we did some refactors on the common libs at the same time
So those refactors were not backported as well.
I am thinking maybe in the future, refactors can be in separated PR so we can backport those refactors immediately.