feat(backup): add option validation for backup creation #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChanYiLin
requested review from
derekbit and
innobead
and removed request for
derekbit
ref: longhorn/longhorn 7070 Signed-off-by: Jack Lin <jack.lin@suse.com>
ChanYiLin
force-pushed
the
LH7070_support_full_backup
branch
from
e5a40e7
to
975c21b
Compare
|
|
|
This is created from the wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#7070
backupstore: If the backup has the option
backupmodea: full, it will pretend there is no last backup, and backup all the blocks of the current volume.longhorn-manager: We need to validate the option of the Backup to check if there is any typo in the option.