Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csi): correct error found in test. #2717

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

james-munson
Copy link
Contributor

@james-munson james-munson commented Apr 2, 2024

Which issue(s) this PR fixes:

Applies to issue https://github.com/longhorn/longhorn/7931

Corrects issue found in testing on backport to 1.5.5 (backport issue longhorn/longhorn#8286)

What this PR does / why we need it:

Special notes for your reviewer:

Still testing change, but want to get eyes on this simple fix.

Additional documentation or context

Signed-off-by: James Munson <james.munson@suse.com>
Copy link
Contributor

@PhanLe1010 PhanLe1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It took me a while to realize the problem too. Tricky one :D

@PhanLe1010 PhanLe1010 merged commit 89b4555 into longhorn:master Apr 8, 2024
5 checks passed
@james-munson
Copy link
Contributor Author

@mergify backport v1.5.x v1.6.x

Copy link

mergify bot commented Apr 8, 2024

backport v1.5.x v1.6.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants