Do not create any instance manager pods for v2 volumes if one is already existing #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbit
force-pushed
the
issue-8456
branch
2 times, most recently
from
dcfc249
to
7d803c7
Compare
|
Ping @shuo-wu @mantissahz @c3y1huang @innobead for review. Thank you. |
|
Updated and ready for review. |
|
@c3y1huang Can you help review the PR? Thank you. |
c3y1huang
reviewed
Jul 1, 2024
derekbit
force-pushed
the
issue-8456
branch
2 times, most recently
from
ae7ce97
to
54b70f4
Compare
c3y1huang
reviewed
Jul 3, 2024
…mes if one is already existing An extra instance manager pod for v2 data engine requires an additional CPU core and 2 GiB of memory. If the resources are insufficient, the instance manager pod will be recreated and retried. To minimize unnecessary retries, do not create any new instance manager pods if one is already running. Longhorn 8456 Signed-off-by: Derek Su <derek.su@suse.com>
c3y1huang
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#8456
What this PR does / why we need it:
An extra instance manager pod for v2 data engine requires an additional CPU core and 2 GiB of memory. If the resources are insufficient, the instance manager pod will be recreated and retried. To minimize unnecessary retries, do not create any new instance manager pods if one is already running.
Special notes for your reviewer:
Additional documentation or context