Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backupbackingimage): add parameters to backup backing image create proto #2974

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat(backupbackingimage): add parameters to backup backing image create proto #2974

merged 1 commit into from
Sep 10, 2024

Conversation

ChanYiLin
Copy link
Contributor

ref: longhorn/longhorn#8884

update

  • backupBackingImage status CRD to add secret and secretNamespace
  • pass the secret and secretNamespace to backing-image-manager through grpc using parameters
  • update backupBackingImage api model to pass the secret and secretNamespace to UI

@ChanYiLin ChanYiLin mentioned this pull request Jul 17, 2024
Open
@ChanYiLin ChanYiLin force-pushed the LH8884_store_secret_in_backupbackingimage branch from 975985a to 4330231 Compare July 17, 2024 08:17
@mergify Mergify
Copy link

mergify bot commented Jul 20, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH8884_store_secret_in_backupbackingimage branch 3 times, most recently from 3cae5d3 to cc57b6d Compare August 28, 2024 07:15
@ChanYiLin
Copy link
Contributor Author

Hi @derekbit
This PR is ready to review
Thanks

@mergify Mergify
Copy link

mergify bot commented Aug 30, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH8884_store_secret_in_backupbackingimage branch 2 times, most recently from a404dab to 7576ddc Compare September 5, 2024 08:41
@ChanYiLin
Copy link
Contributor Author

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

Fixed.

@ChanYiLin
Copy link
Contributor Author

Hi @c3y1huang
This PR is also ready for review. Could you help to take a look, thanks!

@mergify Mergify
Copy link

mergify bot commented Sep 7, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

derekbit
derekbit previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChanYiLin ChanYiLin mentioned this pull request Sep 10, 2024
Merged
1 task
@ChanYiLin
feat(backupbackingimage): add parameters to backup backing image crea…
d2967c6 
…te proto

ref: longhorn/longhorn 8884

Signed-off-by: Jack Lin <jack.lin@suse.com>
@ChanYiLin ChanYiLin force-pushed the LH8884_store_secret_in_backupbackingimage branch from 7576ddc to d2967c6 Compare September 10, 2024 08:44
@ChanYiLin
Copy link
Contributor Author

Fixed the conflicts

derekbit
derekbit approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 9895a58 into longhorn:master Sep 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbit derekbit derekbit approved these changes

@c3y1huang c3y1huang Awaiting requested review from c3y1huang

@shuo-wu shuo-wu Awaiting requested review from shuo-wu

Assignees

@ChanYiLin ChanYiLin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChanYiLin @derekbit