Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backup): clarify deletion log message (backport #3000) #3001

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 24, 2024

Which issue(s) this PR fixes:

No particular linked issue. I saw the following logged when I configured a backup target in my cluster and I was quite confused.

[longhorn-manager-qwx8h longhorn-manager] time="2024-07-24T14:47:28Z" level=info msg="Found 1 backup volumes in the backup target that do not exist in the backup target and need to be deleted" func="controller.

The repeated mention of "backup target" doesn't make sense, and I was worried that backups were being deleted from the target itself, which I would not expect. (That is not the case, so the log can be clarified.)


This is an automatic backport of pull request #3000 done by Mergify.

Signed-off-by: Eric Weber <eric.weber@suse.com>
(cherry picked from commit 00053f1)
@derekbit derekbit merged commit cd50b23 into v1.7.x Jul 25, 2024
6 checks passed
@derekbit derekbit deleted the mergify/bp/v1.7.x/pr-3000 branch July 25, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants