Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(backup): clarify deletion log message (backport #3000) #3001

Merged
merged 1 commit into from
Jul 25, 2024
Merged

chore(backup): clarify deletion log message (backport #3000) #3001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controller/backup_target_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ func (btc *BackupTargetController) syncBackupVolume(backupStoreBackupVolumeNames
// and delete the BackupVolume CR in the cluster
backupVolumesToDelete := clusterBackupVolumesSet.Difference(backupStoreBackupVolumes)
if count := backupVolumesToDelete.Len(); count > 0 {
log.Infof("Found %d backup volumes in the backup target that do not exist in the backup target and need to be deleted", count)
log.Infof("Found %d backup volumes in the backup target that do not exist in the cluster and need to be deleted from the cluster", count)
}
for backupVolumeName := range backupVolumesToDelete {
log.WithField("backupVolume", backupVolumeName).Info("Deleting backup volume from cluster")
Expand Down
2 changes: 1 addition & 1 deletion controller/backup_volume_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ func (bvc *BackupVolumeController) reconcile(backupVolumeName string) (err error
// and delete the Backup CR in the cluster
backupsToDelete := clustersSet.Difference(backupStoreBackups)
if count := backupsToDelete.Len(); count > 0 {
log.Infof("Found %d backups in the backup target that do not exist in the backup target and need to be deleted", count)
log.Infof("Found %d backups in the backup target that do not exist in the cluster and need to be deleted from the cluster", count)
}
for backupName := range backupsToDelete {
if err = bvc.ds.DeleteBackup(backupName); err != nil {
Expand Down