chore(ci): add Conventional Commits GitHub Action #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longhorn 8824 Signed-off-by: Derek Su <derek.su@suse.com>
derekbit
changed the title
c3y1huang
approved these changes
Jul 29, 2024
derekbit
requested review from
ChanYiLin,
mantissahz,
PhanLe1010,
ejweber,
shuo-wu,
james-munson,
a110605,
c3y1huang,
chriscchien and
roger-ryao
14 tasks
innobead
reviewed
Jul 29, 2024
| - name: Lint Pull Request | ||
| uses: amannn/action-semantic-pull-request@v5.5.3 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.CUSTOM_GITHUB_TOKEN }} |
There was a problem hiding this comment.
CUSTOM_GITHUB_TOKEN has more permissions than the built-in one. Can we just use the built-in token (each action will automatically create a token for the action and delete it after the action is finished) instead?
ref: https://github.com/wagoid/commitlint-github-action#token
| build | ||
| ci | ||
| revert | ||
| BREAKING |
There was a problem hiding this comment.
For breaking change, we can just use the second format via !.
BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type.
There was a problem hiding this comment.
After thinking, we can keep this as it's also valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#8824
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context