fix(backup): customize the timeout of backup binary execution #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbit
reviewed
Aug 2, 2024
mantissahz
force-pushed
the
issue8954
branch
2 times, most recently
from
bc9e2ae
to
6764e1a
Compare
derekbit
reviewed
Aug 19, 2024
|
As we discussed, the timeout |
mantissahz
force-pushed
the
issue8954
branch
from
3e423d3
to
40f498a
Compare
Add a default setting `backupExecutionTimeout` ref: longhorn/longhorn 8954,8319 Signed-off-by: James Lu <james.lu@suse.com>
mantissahz
force-pushed
the
issue8954
branch
from
40f498a
to
08546f4
Compare
derekbit
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue # longhorn/longhorn#8954 longhorn/longhorn#8319
What this PR does / why we need it:
Add a default setting
backupExecutionTimeoutSpecial notes for your reviewer:
Additional documentation or context