fix(manager): fix logic for when RWX workload is restarted after node…

[james-munson]

… failure

Which issue(s) this PR fixes:

longhorn/longhorn#9095

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

[ejweber]

Should we remove the code at

longhorn-manager/controller/volume_controller.go

Lines 4524 to 4531 in 69f8cdb

	// kill the workload pods, when the share manager goes into error state
	// easiest approach is to set the RemountRequestedAt variable,
	// since that is already responsible for killing the workload pods
	if sm.Status.State == longhorn.ShareManagerStateError || sm.Status.State == longhorn.ShareManagerStateUnknown {
	volume.Status.RemountRequestedAt = c.nowHandler()
	msg := fmt.Sprintf("Volume %v requested remount at %v", volume.Name, volume.Status.RemountRequestedAt)
	c.eventRecorder.Eventf(volume, corev1.EventTypeNormal, constant.EventReasonRemount, msg)
	}

? If no, should we modify the comment?

[james-munson]

I thought about removing the kick from volume_controller, but it is still necessary in some cases. Comment revised to be more accurate, though.

[ejweber]

LGTM. Thanks!

[mergify]

This pull request is now in conflict. Could you fix it @james-munson? 🙏

[PhanLe1010]

LGTM

Could you please help to resolve the conflict for merging @james-munson ?

[james-munson]

@mergify backport v1.7.x

[mergify]

backport v1.7.x

✅ Backports have been created

• #3169 fix(manager): fix logic for when RWX workload is restarted after node… (backport #3077) has been created for branch v1.7.x but encountered conflicts