fix(encrypt): close encrypted volume if it is opened #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2024
derekbit
reviewed
Sep 5, 2024
mantissahz
force-pushed
the
close-encrypted-volume-before-open-it
branch
from
2c50b01
to
b60a8a6
Compare
mantissahz
force-pushed
the
close-encrypted-volume-before-open-it
branch
from
b60a8a6
to
f8206c6
Compare
c3y1huang
requested changes
Sep 9, 2024
mantissahz
force-pushed
the
close-encrypted-volume-before-open-it
branch
from
f8206c6
to
c6c1511
Compare
derekbit
reviewed
Sep 9, 2024
derekbit
reviewed
Sep 9, 2024
mantissahz
force-pushed
the
close-encrypted-volume-before-open-it
branch
from
c6c1511
to
e11e152
Compare
derekbit
reviewed
Sep 9, 2024
mantissahz
force-pushed
the
close-encrypted-volume-before-open-it
branch
2 times, most recently
from
8d9a273
to
acade6b
Compare
derekbit
reviewed
Sep 9, 2024
In normal process of attaching a volume via CSI, the encrypted volume should be in closed or inactivated state before Longhorn attempts to open it. ref: longhorn/longhorn 9385 Signed-off-by: James Lu <james.lu@suse.com>
mantissahz
force-pushed
the
close-encrypted-volume-before-open-it
branch
from
acade6b
to
6a55644
Compare
c3y1huang
approved these changes
Sep 9, 2024
|
@Mergifyio backport v1.7.x v1.6.x |
✅ Backports have been created
|
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue # longhorn/longhorn#9385
What this PR does / why we need it:
In the normal process of attaching a volume via CSI, the encrypted volume should be closed or inactivated before Longhorn attempts to open it.
Special notes for your reviewer:
Additional documentation or context
Full regression test:
https://ci.longhorn.io/job/private/job/longhorn-tests-regression/7529https://ci.longhorn.io/job/private/job/longhorn-tests-regression/7538/