fix(setting): do not delete the storage class set in the setting default-longhorn-static-storage-class
#3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mantissahz Is it ready? |
Not yet, and I'm testing the modification of Phan's suggestions. |
mantissahz
force-pushed
the
issue9391
branch
from
a3ae29b
to
7fca998
Compare
mantissahz
changed the title
default-longhorn-static-storage-class
derekbit
reviewed
Sep 6, 2024
derekbit
reviewed
Sep 6, 2024
mantissahz
force-pushed
the
issue9391
branch
from
7fca998
to
30e3cb1
Compare
derekbit
reviewed
Sep 7, 2024
Delete the old storage class set in reconciling the `default-longhorn-static-storage-class` setting. Create the storage with a label if the storage class named as the value of `default-longhorn-static-storage-class` setting does not exist. ref: longhorn/longhorn 9391 Signed-off-by: James Lu <james.lu@suse.com>
mantissahz
force-pushed
the
issue9391
branch
from
30e3cb1
to
b71b6c6
Compare
|
@mergify backport v1.7.x v1.6.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue # longhorn/longhorn#9391
What this PR does / why we need it:
Delete the old storage class set in reconciling the
default-longhorn-static-storage-classsetting.Create the storage with a label if the storage class named as the value of
default-longhorn-static-storage-classsetting does not exist.Special notes for your reviewer:
Additional documentation or context