fix(instance-manager): missing required labels after manager crashed #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… node when labels are missing longhorn/longhorn-9464 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
…abels are missing longhorn/longhorn-9464 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
derekbit
reviewed
Sep 16, 2024
|
@mergify backport v1.6.x v1.7.x |
✅ Backports have been created
|
This was referenced Sep 16, 2024
c3y1huang
deleted the
9464-missing-instance-manager-lables-after-manager-crash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9464
What this PR does / why we need it:
When the Longhorn manager starts, it will attempt to retrieve existing instance managers using the label selector or create new ones if they do not exist. If the creation of an instance manager fails, it may be because the instance manager was created but the webhook server missed patching the required selector labels due to the pod crash. In such cases, actively deletes the instance manager and requeues the node. This process allows the node controller to recreate the instance manager, triggering the webhook to reapply the necessary labels.
Special notes for your reviewer:
NoneAdditional documentation or context
None