Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update registry.suse.com/bci/golang docker tag to v1.23 (master) #283

Merged
merged 3 commits into from
Sep 7, 2024
Merged

chore(deps): update registry.suse.com/bci/golang docker tag to v1.23 (master) #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
876f4a5
chore(deps): update registry.suse.com/bci/golang docker tag to v1.23
renovate[bot] Sep 7, 2024
37ad3b3
chore(dockerfile): update golangci-lint to v1.60.3
derekbit Sep 7, 2024
2632578
fix: non-constant format string in call to ...
derekbit Sep 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Dockerfile.dapper
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.suse.com/bci/golang:1.22
FROM registry.suse.com/bci/golang:1.23

ARG DAPPER_HOST_ARCH
ARG http_proxy
Expand All @@ -12,6 +12,8 @@ ENV DAPPER_OUTPUT bin coverage.out
ENV DAPPER_RUN_ARGS --privileged -v /dev:/host/dev -v /proc:/host/proc
ENV DAPPER_SOURCE /go/src/github.com/longhorn/longhorn-share-manager

ENV GOLANGCI_LINT_VERSION="v1.60.3"

WORKDIR ${DAPPER_SOURCE}
ENTRYPOINT ["./scripts/entry"]
CMD ["ci"]
Expand All @@ -24,7 +26,7 @@ RUN zypper -n install wget git jq tar gzip gcc linux-glibc-devel glibc-devel-sta
rm -rf /var/cache/zypp/*

# Install golangci-lint
RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b /go/bin v1.55.2
RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}

# Install docker buildx: The docker version in dapper is too old to have buildx. Install it manually.
RUN curl -sSfLO https://github.com/docker/buildx/releases/download/v0.13.1/buildx-v0.13.1.linux-${ARCH} && \
Expand Down
2 changes: 1 addition & 1 deletion pkg/rpc/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ func (s *ShareManagerServer) Mount(ctx context.Context, req *emptypb.Empty) (res
isMountPoint, err := mounter.IsMountPoint(mountPath)
if err != nil {
err = errors.Wrapf(err, "failed to check mount point %v", mountPath)
return &emptypb.Empty{}, grpcstatus.Errorf(grpccodes.Internal, err.Error())
return &emptypb.Empty{}, grpcstatus.Errorf(grpccodes.Internal, "%v", err)
}
if !isMountPoint {
log.Info("Mounting volume")
Expand Down