Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): DR volume #192

Merged
merged 7 commits into from
Aug 28, 2024
Merged

feat(v2): DR volume #192

merged 7 commits into from
Aug 28, 2024

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#6613

What this PR does / why we need it:

Implement incremental restore.

Special notes for your reviewer:

None

Additional documentation or context

None

@c3y1huang c3y1huang self-assigned this Jul 31, 2024
@c3y1huang c3y1huang force-pushed the feat-v2-dr-volume branch 2 times, most recently from 717505d to 5efd74b Compare July 31, 2024 05:54
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 94 lines in your changes missing coverage. Please review.

Project coverage is 8.87%. Comparing base (e2b1279) to head (0d60bae).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/spdk/engine.go 0.00% 51 Missing ⚠️
pkg/spdk/replica.go 0.00% 41 Missing ⚠️
pkg/spdk/restore.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #192      +/-   ##
========================================
- Coverage   8.97%   8.87%   -0.11%     
========================================
  Files         22      22              
  Lines       6994    7076      +82     
========================================
  Hits         628     628              
- Misses      6287    6369      +82     
  Partials      79      79              
Flag Coverage Δ
unittests 8.87% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Outdated Show resolved Hide resolved
@c3y1huang c3y1huang force-pushed the feat-v2-dr-volume branch 4 times, most recently from 119fcfd to f2cf48a Compare August 6, 2024 06:11
Copy link

mergify bot commented Aug 9, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

@c3y1huang c3y1huang force-pushed the feat-v2-dr-volume branch 2 times, most recently from 7ceda35 to b2b2330 Compare August 12, 2024 00:31
Copy link

mergify bot commented Aug 12, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

Copy link

mergify bot commented Aug 26, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

@c3y1huang c3y1huang force-pushed the feat-v2-dr-volume branch 3 times, most recently from b92e887 to 5526776 Compare August 27, 2024 04:31
shuo-wu
shuo-wu previously approved these changes Aug 27, 2024
longhorn/longhorn-6613

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn/longhorn-6613

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
…itiator

longhorn/longhorn-6613

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn/longhorn-6613

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
DamiaSan
DamiaSan previously approved these changes Aug 27, 2024
shuo-wu
shuo-wu previously approved these changes Aug 27, 2024
pkg/spdk/engine.go Outdated Show resolved Hide resolved
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Only one minor comment.

longhorn/longhorn-6613

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn/longhorn-6613

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn/longhorn-6613

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @c3y1huang. Awesome task.

@derekbit derekbit merged commit 4ced424 into longhorn:main Aug 28, 2024
5 checks passed
@c3y1huang c3y1huang deleted the feat-v2-dr-volume branch August 28, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants