Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(support-bundle): agent with node-selector and taint-toleration #1286

Conversation

c3y1huang
Copy link
Collaborator

@c3y1huang c3y1huang self-assigned this Mar 22, 2023
@c3y1huang c3y1huang changed the title test(auto): support bundle agent with node-selector and taint-toleration test(support-bundle): agent with node-selector and taint-toleration Mar 22, 2023
@c3y1huang c3y1huang force-pushed the fix-support-bundle-agent-missing-nodeselector-taintolerate branch 2 times, most recently from 36f35f7 to 19e4358 Compare March 22, 2023 06:49
@innobead innobead requested a review from a team March 22, 2023 07:12
@c3y1huang c3y1huang force-pushed the fix-support-bundle-agent-missing-nodeselector-taintolerate branch 2 times, most recently from f56b05f to 4a9367d Compare April 7, 2023 01:44
Ref: 5614

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Ref: 5614

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the fix-support-bundle-agent-missing-nodeselector-taintolerate branch from 4a9367d to b51a1b7 Compare April 7, 2023 04:40
@c3y1huang c3y1huang marked this pull request as ready for review April 7, 2023 04:43
@c3y1huang
Copy link
Collaborator Author

Should merge this with longhorn/longhorn-manager#1798 to avoid affecting regression runs. cc @longhorn/qa

Ref: longhorn/longhorn#5639 (comment)

Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is good.

@innobead innobead merged commit 1b58dce into longhorn:master Apr 10, 2023
@innobead
Copy link
Member

@Mergifyio backport v1.4.x

@mergify
Copy link

mergify bot commented Apr 10, 2023

backport v1.4.x

✅ Backports have been created

@c3y1huang c3y1huang deleted the fix-support-bundle-agent-missing-nodeselector-taintolerate branch April 11, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants