fix(auto): download-support-bundle.sh doesn't tolerate master node #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
|
I don't know how to test this in the pipeline. @yangchiu |
|
Close in favor of #1309. |
c3y1huang
deleted the
fix-no-master-node-taint-running-download-support-bundle-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
download-support-bundle.shcannot complete support-bundle generation if one of the tests unsets the master node taint-toleration without calling reset_settings when it's done. example test:test_setting_update_with_invalid_value_via_configmap.This fix ensures regression runs always have toleration for the master node before generating the support bundle.