Skip to content

Commit

Permalink
fix makefile typo and add make enter command
Browse files Browse the repository at this point in the history
Signed-off-by: andy.lee <andy.lee@suse.com>
  • Loading branch information
a110605 committed Jun 5, 2024
1 parent 02650da commit 1634e99
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
7 changes: 5 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ VERSION = $(shell ./scripts/version)
REPO = longhornio
NAME = longhorn-ui
INSTANCE = default
LONHORN_MANAGER_IP = http://localhost:9500
LONGHORN_MANAGER_IP = http://localhost:9500
PORT = 8000
IMAGE = $(REPO)/$(NAME):$(VERSION)

BASE_IMAGE = $(shell grep FROM Dockerfile | grep -vi ' AS ' | awk '{print $$2}' )

.PHONY: build push shell run start stop rm release
.PHONY: build push shell run start stop rm release enter

build:
# update base image to get latest changes
Expand All @@ -25,4 +25,7 @@ stop:
run:
docker run -d --name $(NAME)-$(INSTANCE) -p $(PORT):8000 -e LONGHORN_MANAGER_IP=$(LONGHORN_MANAGER_IP) $(REPO)/$(NAME):$(VERSION)

enter:
docker exec -it $(NAME)-$(INSTANCE) /bin/bash

default: build
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Prerequisites:

Setup:
```bash
git clone 'https://github.com/rancher/longhorn-ui'
git clone 'https://github.com/longhorn/longhorn-ui'
cd 'longhorn-ui'
npm ci
```
Expand All @@ -31,7 +31,7 @@ Compiling for distribution
npm run build
```

Build and run a docker image
Build and run a docker image, longhorn UI will listen on localhost:8000
```bash
make
make LONGHORN_MANAGER_IP=http://longhorn:9500 run
Expand Down

0 comments on commit 1634e99

Please sign in to comment.