From 1634e991b459c26d8edbed770211986969188521 Mon Sep 17 00:00:00 2001 From: "andy.lee" Date: Tue, 4 Jun 2024 11:11:00 +0800 Subject: [PATCH] fix makefile typo and add make enter command Signed-off-by: andy.lee --- Makefile | 7 +++++-- README.md | 4 ++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index ad2115f95..6eb9f3864 100644 --- a/Makefile +++ b/Makefile @@ -3,13 +3,13 @@ VERSION = $(shell ./scripts/version) REPO = longhornio NAME = longhorn-ui INSTANCE = default -LONHORN_MANAGER_IP = http://localhost:9500 +LONGHORN_MANAGER_IP = http://localhost:9500 PORT = 8000 IMAGE = $(REPO)/$(NAME):$(VERSION) BASE_IMAGE = $(shell grep FROM Dockerfile | grep -vi ' AS ' | awk '{print $$2}' ) -.PHONY: build push shell run start stop rm release +.PHONY: build push shell run start stop rm release enter build: # update base image to get latest changes @@ -25,4 +25,7 @@ stop: run: docker run -d --name $(NAME)-$(INSTANCE) -p $(PORT):8000 -e LONGHORN_MANAGER_IP=$(LONGHORN_MANAGER_IP) $(REPO)/$(NAME):$(VERSION) +enter: + docker exec -it $(NAME)-$(INSTANCE) /bin/bash + default: build diff --git a/README.md b/README.md index 0a4ae45be..fe08f726f 100644 --- a/README.md +++ b/README.md @@ -12,7 +12,7 @@ Prerequisites: Setup: ```bash - git clone 'https://github.com/rancher/longhorn-ui' + git clone 'https://github.com/longhorn/longhorn-ui' cd 'longhorn-ui' npm ci ``` @@ -31,7 +31,7 @@ Compiling for distribution npm run build ``` -Build and run a docker image +Build and run a docker image, longhorn UI will listen on localhost:8000 ```bash make make LONGHORN_MANAGER_IP=http://longhorn:9500 run