Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate to GitHub actions #720

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

FrankYang0529
Copy link
Contributor

Signed-off-by: PoAn Yang <poan.yang@suse.com>
Signed-off-by: PoAn Yang <poan.yang@suse.com>
@a110605
Copy link
Contributor

a110605 commented Apr 30, 2024

Hi @FrankYang0529 , shall we need to remove continuous-integration/drone/pr in

- check-success=continuous-integration/drone/pr
?

- name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirm, you will add secrets DOCKER_USERNAME and DOCKER_PASSWORD somewhere in github action, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, already setup in organization level secrets.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for confirmation.

@FrankYang0529
Copy link
Contributor Author

Hi @FrankYang0529 , shall we need to remove continuous-integration/drone/pr in

- check-success=continuous-integration/drone/pr

?

Yeah, we will do it after the PR is merged. Thanks.

@innobead
Copy link
Member

innobead commented May 1, 2024

@a110605 We need to add unit tests in the PR check in the future, also for Harvester.

@innobead innobead merged commit 46062fc into longhorn:master May 1, 2024
5 checks passed
@FrankYang0529 FrankYang0529 deleted the LH-8039 branch May 2, 2024 03:59
@FrankYang0529
Copy link
Contributor Author

@mergify backport v1.6.x

Copy link

mergify bot commented Jun 14, 2024

backport v1.6.x

✅ Backports have been created

@FrankYang0529
Copy link
Contributor Author

@mergify backport v1.5.x

Copy link

mergify bot commented Jun 17, 2024

backport v1.5.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants