Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backing image clean up disk wordings and modal style #738

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

a110605
Copy link
Contributor

@a110605 a110605 commented Jun 3, 2024

What's change in this PR ?

Update backing image clean up disk wordings and modal style (from writer suggestion comment)

Related Issue

[IMPROVEMENT] BackingImage UI improvement

Test Result

Screenshot 2024-06-03 at 11 54 09 AM

Copy link

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the change.

src/routes/backingImage/DiskStateMapActions.js Outdated Show resolved Hide resolved
torchiaf
torchiaf previously approved these changes Jun 5, 2024
Copy link

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 force-pushed the backing_page_update_wording branch from 386e111 to 5e53bc3 Compare June 6, 2024 01:32
Copy link

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 199a36b into longhorn:master Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants