Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apply All button and encrypted option in Create DR volume bulk action #742

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

a110605
Copy link
Contributor

@a110605 a110605 commented Jun 6, 2024

What's this PR change

Based on the demo feedback, change

  • Remove previous & next buttons. Instead add Apply All button for one-click to apply current config to all the others
  • Add encypted option in Create DR volume bulk action (discuss thread)
  • Still allow user to click each tab to fill in the restore volume config / DR config

Issue

[IMPROVEMENT] Restore Latest Backup should be applied with BackingImage name value

Result

Restore Latest Backup

after.mov

Create Disaster Recovery Volume

create_DR

@a110605 a110605 self-assigned this Jun 6, 2024
@a110605 a110605 changed the title Refactor and add apply same config button Refactor and add Apply All button Jun 6, 2024
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 requested review from derekbit, torchiaf and a team June 6, 2024 09:18
@a110605 a110605 marked this pull request as ready for review June 6, 2024 09:20
@a110605 a110605 changed the title Refactor and add Apply All button Add Apply All button and encrypted option in Create DR volume bulk action Jun 6, 2024
Copy link

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 requested a review from a team June 11, 2024 02:15
@a110605 a110605 merged commit c7b69e6 into longhorn:master Jun 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants