Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Implement/fix the unit tests of Volume Attachment and volume controller #6005

Closed
PhanLe1010 opened this issue May 26, 2023 · 4 comments
Assignees
Labels
area/volume-attach-detach Volume attach & detach related backport/1.5.1 component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO)
Milestone

Comments

@PhanLe1010
Copy link
Contributor

Implement/fix unit tests of Volume Attachment and Volume controller

https://github.com/longhorn/longhorn-manager/blob/master/controller/volume_attachment_controller_test.go
https://github.com/longhorn/longhorn-manager/blob/master/controller/volume_controller_test.go

@PhanLe1010 PhanLe1010 added the kind/improvement Request for improvement of existing function label May 26, 2023
@PhanLe1010 PhanLe1010 self-assigned this May 26, 2023
@PhanLe1010 PhanLe1010 added this to the v1.5.0 milestone May 26, 2023
@innobead innobead added priority/0 Must be implement or fixed in this release (managed by PO) component/longhorn-manager Longhorn manager (control plane) area/volume-attach-detach Volume attach & detach related labels May 29, 2023
@innobead innobead modified the milestones: v1.5.0, v1.6.0 Jun 1, 2023
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Jul 7, 2023

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at: [IMPROVEMENT] Implement/fix the unit tests of Volume Attachment and volume controller #6005 (comment)

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at Implement/fix the unit tests of Volume Attachment and volume controller longhorn-manager#2053

  • Which areas/issues this PR might have potential impacts on?
    Area Image Build
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@innobead
Copy link
Member

Also, need to backport this to 1.5.x even if its unit tests because it will help with the PR check.

@PhanLe1010
Copy link
Contributor Author

Test plan:
Just make sure that longhorn-manager image is built successfully

@roger-ryao roger-ryao self-assigned this Aug 17, 2023
@roger-ryao
Copy link

Referring to #6303 (comment), it was confirmed through https://drone-pr.longhorn.io/longhorn/longhorn-manager/5596/1/3 that the issue has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/volume-attach-detach Volume attach & detach related backport/1.5.1 component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO)
Projects
Status: Closed
Development

No branches or pull requests

4 participants