chore: deprecate EngineBackupRestoreFinish RPC

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn · Sep 25, 2024 · 486da0a · 486da0a
1 parent e60fb0a
commit 486da0a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/protobuf/imrpc/proxy.proto b/protobuf/imrpc/proxy.proto
@@ -35,7 +35,7 @@ service ProxyEngineService {
 	rpc SnapshotBackupStatus(EngineSnapshotBackupStatusRequest) returns (EngineSnapshotBackupStatusProxyResponse);
 	rpc BackupRestore(EngineBackupRestoreRequest) returns (EngineBackupRestoreProxyResponse);
 	rpc BackupRestoreStatus(ProxyEngineRequest) returns (EngineBackupRestoreStatusProxyResponse);
-	rpc BackupRestoreFinish(EngineBackupRestoreFinishRequest) returns (google.protobuf.Empty);
+	rpc BackupRestoreFinish(EngineBackupRestoreFinishRequest) returns (google.protobuf.Empty);  // Deprecated: retained for compatibility with v1.7.x and earlier versions.
 	rpc CleanupBackupMountPoints(google.protobuf.Empty) returns (google.protobuf.Empty);
 
 	rpc ReplicaAdd(EngineReplicaAddRequest) returns (google.protobuf.Empty);
@@ -230,6 +230,7 @@ message EngineBackupRestoreStatus {
 	string backup_url = 8;
 }
 
+// Deprecated: retained for compatibility with v1.7.x and earlier versions.
 message EngineBackupRestoreFinishRequest {
 	ProxyEngineRequest proxy_engine_request = 1;
 }

diff --git a/protobuf/spdkrpc/spdk.proto b/protobuf/spdkrpc/spdk.proto
@@ -52,7 +52,7 @@ service SPDKService {
     rpc EngineBackupCreate(BackupCreateRequest) returns (BackupCreateResponse) {}
     rpc EngineBackupStatus(BackupStatusRequest) returns (BackupStatusResponse) {}
     rpc EngineBackupRestore(EngineBackupRestoreRequest) returns (EngineBackupRestoreResponse) {}
-    rpc EngineBackupRestoreFinish(EngineBackupRestoreFinishRequest) returns (google.protobuf.Empty) {}
+    rpc EngineBackupRestoreFinish(EngineBackupRestoreFinishRequest) returns (google.protobuf.Empty) {}  // Deprecated: retained for compatibility with v1.7.x and earlier versions.
     rpc EngineRestoreStatus(RestoreStatusRequest) returns (RestoreStatusResponse) {}
 
     rpc DiskCreate(DiskCreateRequest) returns (Disk);
@@ -387,6 +387,7 @@ message EngineBackupRestoreResponse {
     map<string, string> errors = 4;
 }
 
+// Deprecated: retained for compatibility with v1.7.x and earlier versions.
 message EngineBackupRestoreFinishRequest {
     string engine_name = 1;
 }