Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove EngineBackupRestoreFinish RPC #25

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#6613

What this PR does / why we need it:

Remove EngineBackupRestoreFinish RPC because it's currently not used by either v1 or v2 engines.

Special notes for your reviewer:

None

Additional documentation or context

longhorn/longhorn-spdk-engine#192 (comment)

longhorn/longhorn-6613

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn/longhorn-6613

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang self-assigned this Aug 26, 2024
@c3y1huang c3y1huang marked this pull request as ready for review August 26, 2024 03:51
@c3y1huang c3y1huang changed the title Chore: remove EngineBackupRestoreFinish RPC chore: remove EngineBackupRestoreFinish RPC Aug 26, 2024
@shuo-wu shuo-wu enabled auto-merge August 27, 2024 03:55
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit disabled auto-merge August 27, 2024 04:27
@derekbit derekbit merged commit af8f10e into longhorn:main Aug 27, 2024
2 checks passed
@c3y1huang c3y1huang deleted the feat-v2-dr-volume branch August 27, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants