Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(1.7.0): update important-notes #972

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

derekbit
Copy link
Member

@derekbit derekbit commented Aug 19, 2024

  • update important-notes
  • remove old deploy/important-notes

Which issue(s) this PR fixes:

Issue longhorn/longhorn#8997

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit e581b83
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66c41218d0071200087f1d11
😎 Deploy Preview https://deploy-preview-972--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM.

Need @jillian-maroket or @jhkrug to update wording if necessary.

content/docs/1.7.0/important-notes/_index.md Outdated Show resolved Hide resolved
@mantissahz
Copy link
Contributor

LGTM.

innobead
innobead previously approved these changes Aug 20, 2024
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done. FYI I used "Longhorn CLI" instead of "longhornctl" as the official tool name. "longhornctl" is mentioned only once (as the binary name).

content/docs/1.7.0/important-notes/_index.md Outdated Show resolved Hide resolved
content/docs/1.7.0/important-notes/_index.md Outdated Show resolved Hide resolved
content/docs/1.7.0/important-notes/_index.md Outdated Show resolved Hide resolved
content/docs/1.7.0/important-notes/_index.md Outdated Show resolved Hide resolved
content/docs/1.7.0/important-notes/_index.md Outdated Show resolved Hide resolved
content/docs/1.7.0/important-notes/_index.md Outdated Show resolved Hide resolved
- update important-notes
- remove old deploy/important-notes

Signed-off-by: Derek Su <derek.su@suse.com>
@derekbit derekbit merged commit 7da25f7 into longhorn:master Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants