Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate "enum" tag #53

Open
nathancastelein opened this issue Sep 17, 2018 · 3 comments
Open

Deprecate "enum" tag #53

nathancastelein opened this issue Sep 17, 2018 · 3 comments

Comments

@nathancastelein
Copy link

The new validator package (v9) introduces the oneof tag: https://godoc.org/gopkg.in/go-playground/validator.v9#hdr-One_Of

There is no more need to document the tonic enum tag IMO.
@wI2L
Copy link
Collaborator

wI2L commented Sep 18, 2018

We kept it so the package remains backward compatible.

@nathancastelein
Copy link
Author

Yes, but we should remove its usage from README :)

@wI2L
Copy link
Collaborator

wI2L commented Oct 1, 2018

@Garbage-Collector I'd rather mark it as deprecated explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wI2L @nathancastelein