From 09c40521f4c62aa801b118a5cc81e265ada6a455 Mon Sep 17 00:00:00 2001 From: Chongyi Zheng Date: Fri, 15 Sep 2023 15:21:27 -0400 Subject: [PATCH 01/11] Drop Node.js 14 and 16 --- .github/ISSUE_TEMPLATE/bug_report.yaml | 2 +- .github/workflows/auto-test.yml | 8 +- .github/workflows/close-incorrect-issue.yml | 2 +- install.sh | 116 ++++++++++---------- package.json | 2 +- 5 files changed, 65 insertions(+), 65 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yaml b/.github/ISSUE_TEMPLATE/bug_report.yaml index 0724442054..81609f175b 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yaml +++ b/.github/ISSUE_TEMPLATE/bug_report.yaml @@ -86,7 +86,7 @@ body: attributes: label: "🟩 NodeJS Version" description: "If running with Node.js? which version are you running?" - placeholder: "Ex. 14.18.0" + placeholder: "Ex. 18.17.1" validations: required: false - type: textarea diff --git a/.github/workflows/auto-test.yml b/.github/workflows/auto-test.yml index 2de22fd5b0..5ec39829f1 100644 --- a/.github/workflows/auto-test.yml +++ b/.github/workflows/auto-test.yml @@ -22,7 +22,7 @@ jobs: strategy: matrix: os: [macos-latest, ubuntu-latest, windows-latest, ARM64] - node: [ 14, 20.5 ] + node: [ 18, 20.5 ] # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ steps: @@ -50,7 +50,7 @@ jobs: strategy: matrix: os: [ ARMv7 ] - node: [ 14, 20 ] + node: [ 18, 20 ] # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ steps: @@ -101,10 +101,10 @@ jobs: - run: git config --global core.autocrlf false # Mainly for Windows - uses: actions/checkout@v3 - - name: Use Node.js 14 + - name: Use Node.js 18 uses: actions/setup-node@v3 with: - node-version: 14 + node-version: 18 - run: npm install - run: npm run build - run: npm run cy:run:unit diff --git a/.github/workflows/close-incorrect-issue.yml b/.github/workflows/close-incorrect-issue.yml index 762bc96885..b6360c3b12 100644 --- a/.github/workflows/close-incorrect-issue.yml +++ b/.github/workflows/close-incorrect-issue.yml @@ -11,7 +11,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node-version: [16] + node-version: [18] steps: - uses: actions/checkout@v3 diff --git a/install.sh b/install.sh index d965867cbc..7170232e52 100644 --- a/install.sh +++ b/install.sh @@ -26,42 +26,42 @@ function checkNode { "echo" "-e" "Node Version: ""$nodeVersion" _0="12" if [ $(($nodeVersion <= $_0)) == 1 ]; then - "echo" "-e" "Error: Required Node.js 14" - "exit" "1" -fi + "echo" "-e" "Error: Required Node.js 18" + "exit" "1" + fi } function deb { nodeCheck=$(node -v) apt --yes update if [ "$nodeCheck" != "" ]; then - "checkNode" + "checkNode" else # Old nodejs binary name is "nodejs" check=$(nodejs --version) if [ "$check" != "" ]; then "echo" "-e" "Error: 'node' command is not found, but 'nodejs' command is found. Your NodeJS should be too old." - exit 1 -fi + exit 1 + fi curlCheck=$(curl --version) if [ "$curlCheck" == "" ]; then "echo" "-e" "Installing Curl" - apt --yes install curl -fi - "echo" "-e" "Installing Node.js 16" - curl -sL https://deb.nodesource.com/setup_16.x | bash - > log.txt + apt --yes install curl + fi + "echo" "-e" "Installing Node.js 18" + curl -sL https://deb.nodesource.com/setup_18.x | bash - >log.txt apt --yes install nodejs node -v nodeCheckAgain=$(node -v) if [ "$nodeCheckAgain" == "" ]; then "echo" "-e" "Error during Node.js installation" - exit 1 -fi + exit 1 + fi fi check=$(git --version) if [ "$check" == "" ]; then "echo" "-e" "Installing Git" - apt --yes install git -fi + apt --yes install git + fi } if [ "$type" == "local" ]; then defaultInstallPath="/opt/uptime-kuma" @@ -75,12 +75,12 @@ if [ "$type" == "local" ]; then distribution="ubuntu" # Get ubuntu version . /etc/lsb-release - version="$DISTRIB_RELEASE" -fi + version="$DISTRIB_RELEASE" + fi if [ "$os" == "Debian" ]; then - distribution="debian" -fi -fi + distribution="debian" + fi + fi fi arch=$(uname -i) "echo" "-e" "Your OS: ""$os" @@ -92,22 +92,22 @@ fi else "read" "-p" "Listening Port [$defaultPort]: " "port" if [ "$port" == "" ]; then - port="$defaultPort" -fi + port="$defaultPort" + fi fi if [ "$2" != "" ]; then installPath="$2" else "read" "-p" "Installation Path [$defaultInstallPath]: " "installPath" if [ "$installPath" == "" ]; then - installPath="$defaultInstallPath" -fi + installPath="$defaultInstallPath" + fi fi # CentOS if [ "$distribution" == "rhel" ]; then nodeCheck=$(node -v) if [ "$nodeCheck" != "" ]; then - "checkNode" + "checkNode" else dnfCheck=$(dnf --version) # Use yum @@ -115,41 +115,41 @@ fi curlCheck=$(curl --version) if [ "$curlCheck" == "" ]; then "echo" "-e" "Installing Curl" - yum -y -q install curl -fi - "echo" "-e" "Installing Node.js 16" - curl -sL https://rpm.nodesource.com/setup_16.x | bash - > log.txt + yum -y -q install curl + fi + "echo" "-e" "Installing Node.js 18" + curl -sL https://rpm.nodesource.com/setup_18.x | bash - >log.txt yum install -y -q nodejs else curlCheck=$(curl --version) if [ "$curlCheck" == "" ]; then "echo" "-e" "Installing Curl" - dnf -y install curl -fi - "echo" "-e" "Installing Node.js 16" - curl -sL https://rpm.nodesource.com/setup_16.x | bash - > log.txt + dnf -y install curl + fi + "echo" "-e" "Installing Node.js 18" + curl -sL https://rpm.nodesource.com/setup_18.x | bash - >log.txt dnf install -y nodejs fi node -v nodeCheckAgain=$(node -v) if [ "$nodeCheckAgain" == "" ]; then "echo" "-e" "Error during Node.js installation" - exit 1 -fi + exit 1 + fi fi check=$(git --version) if [ "$check" == "" ]; then "echo" "-e" "Installing Git" - yum -y -q install git -fi + yum -y -q install git + fi # Ubuntu else if [ "$distribution" == "ubuntu" ]; then - "deb" + "deb" # Debian else if [ "$distribution" == "debian" ]; then - "deb" + "deb" else # Unknown distribution error=$((0)) @@ -157,18 +157,18 @@ fi if [ "$check" == "" ]; then error=$((1)) "echo" "-e" "Error: git is not found!" - "echo" "-e" "help: an installation guide is available at https://git-scm.com/book/en/v2/Getting-Started-Installing-Git" -fi + "echo" "-e" "help: an installation guide is available at https://git-scm.com/book/en/v2/Getting-Started-Installing-Git" + fi check=$(node -v) if [ "$check" == "" ]; then error=$((1)) "echo" "-e" "Error: node is not found" - "echo" "-e" "help: an installation guide is available at https://nodejs.org/en/download" -fi + "echo" "-e" "help: an installation guide is available at https://nodejs.org/en/download" + fi if [ $(($error > 0)) == 1 ]; then "echo" "-e" "Please install above missing software" - exit 1 -fi + exit 1 + fi fi fi fi @@ -176,15 +176,15 @@ fi if [ "$check" == "" ]; then "echo" "-e" "Installing PM2" npm install pm2 -g && pm2 install pm2-logrotate - pm2 startup -fi + pm2 startup + fi # Check again check=$(pm2 --version) if [ "$check" == "" ]; then "echo" "-e" "Error: pm2 is not found!" "echo" "-e" "help: an installation guide is available at https://pm2.keymetrics.io/docs/usage/quick-start/" - exit 1 -fi + exit 1 + fi mkdir -p $installPath cd $installPath git clone https://github.com/louislam/uptime-kuma.git . @@ -196,29 +196,29 @@ else if [ "$check" == "" ]; then "echo" "-e" "Error: docker is not found!" "echo" "-e" "help: an installation guide is available at https://docs.docker.com/desktop/" - exit 1 -fi + exit 1 + fi check=$(docker info) if [[ "$check" == *"Is the docker daemon running"* ]]; then - "echo" "Error: docker is not running" - "echo" "help: a troubleshooting guide is available at https://docs.docker.com/config/daemon/troubleshoot/" - "exit" "1" - fi + "echo" "Error: docker is not running" + "echo" "help: a troubleshooting guide is available at https://docs.docker.com/config/daemon/troubleshoot/" + "exit" "1" + fi if [ "$3" != "" ]; then port="$3" else "read" "-p" "Expose Port [$defaultPort]: " "port" if [ "$port" == "" ]; then - port="$defaultPort" -fi + port="$defaultPort" + fi fi if [ "$2" != "" ]; then volume="$2" else "read" "-p" "Volume Name [$defaultVolume]: " "volume" if [ "$volume" == "" ]; then - volume="$defaultVolume" -fi + volume="$defaultVolume" + fi fi "echo" "-e" "Port: $port" "echo" "-e" "Volume: $volume" diff --git a/package.json b/package.json index 4814da6a7a..1153b998a6 100644 --- a/package.json +++ b/package.json @@ -7,7 +7,7 @@ "url": "https://github.com/louislam/uptime-kuma.git" }, "engines": { - "node": "14 || 16 || 18 || >= 20.4.0" + "node": "18 || >= 20.4.0" }, "scripts": { "install-legacy": "npm install", From d541ec02e0d26376fee41d99c039894fb5778928 Mon Sep 17 00:00:00 2001 From: Chongyi Zheng Date: Fri, 15 Sep 2023 15:27:14 -0400 Subject: [PATCH 02/11] Update README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 029081d138..a1018d14fd 100644 --- a/README.md +++ b/README.md @@ -54,7 +54,7 @@ Requirements: - ✅ Major Linux distros such as Debian, Ubuntu, CentOS, Fedora and ArchLinux etc. - ✅ Windows 10 (x64), Windows Server 2012 R2 (x64) or higher - ❌ Replit / Heroku -- [Node.js](https://nodejs.org/en/download/) 14 / 16 / 18 / 20.4 +- [Node.js](https://nodejs.org/en/download/) 18 / 20.4 - [npm](https://docs.npmjs.com/cli/) >= 7 - [Git](https://git-scm.com/downloads) - [pm2](https://pm2.keymetrics.io/) - For running Uptime Kuma in the background From b8f69d49e71a48e6044bb5e840dab93026b78623 Mon Sep 17 00:00:00 2001 From: Chongyi Zheng Date: Fri, 15 Sep 2023 16:29:27 -0400 Subject: [PATCH 03/11] Bump version in contributing.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 20d0749fca..9bd7d8fedf 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -106,7 +106,7 @@ I personally do not like something that requires so many configurations before y ## Tools -- [`Node.js`](https://nodejs.org/) >= 14 +- [`Node.js`](https://nodejs.org/) >= 18 - [`npm`](https://www.npmjs.com/) >= 8.5 - [`git`](https://git-scm.com/) - IDE that supports [`ESLint`](https://eslint.org/) and EditorConfig (I am using [`IntelliJ IDEA`](https://www.jetbrains.com/idea/)) From 1b3ad1f96ab78fde2d72f83d7c61aa08665da2f2 Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Wed, 20 Mar 2024 13:21:13 +0100 Subject: [PATCH 04/11] removed install.sh as in master --- install.sh | 228 ----------------------------------------------------- 1 file changed, 228 deletions(-) delete mode 100644 install.sh diff --git a/install.sh b/install.sh deleted file mode 100644 index 7170232e52..0000000000 --- a/install.sh +++ /dev/null @@ -1,228 +0,0 @@ -# install.sh is generated by ./extra/install.batsh, do not modify it directly. -# "npm run compile-install-script" to compile install.sh -# The command is working on Windows PowerShell and Docker for Windows only. -# curl -o kuma_install.sh https://raw.githubusercontent.com/louislam/uptime-kuma/master/install.sh && sudo bash kuma_install.sh -"echo" "-e" "=====================" -"echo" "-e" "Uptime Kuma Install Script" -"echo" "-e" "=====================" -"echo" "-e" "Supported OS: Ubuntu >= 16.04, Debian and CentOS/RHEL 7/8" -"echo" "-e" "---------------------------------------" -"echo" "-e" "This script is designed for Linux and basic usage." -"echo" "-e" "For advanced usage, please go to https://github.com/louislam/uptime-kuma/wiki/Installation" -"echo" "-e" "---------------------------------------" -"echo" "-e" "" -"echo" "-e" "Local - Install Uptime Kuma on your current machine with git, Node.js and pm2" -"echo" "-e" "Docker - Install Uptime Kuma Docker container" -"echo" "-e" "" -if [ "$1" != "" ]; then - type="$1" -else - "read" "-p" "Which installation method do you prefer? [DOCKER/local]: " "type" -fi -defaultPort="3001" -function checkNode { - local _0 - nodeVersion=$(node -e 'console.log(process.versions.node.split(`.`)[0])') - "echo" "-e" "Node Version: ""$nodeVersion" - _0="12" - if [ $(($nodeVersion <= $_0)) == 1 ]; then - "echo" "-e" "Error: Required Node.js 18" - "exit" "1" - fi -} -function deb { - nodeCheck=$(node -v) - apt --yes update - if [ "$nodeCheck" != "" ]; then - "checkNode" - else - # Old nodejs binary name is "nodejs" - check=$(nodejs --version) - if [ "$check" != "" ]; then - "echo" "-e" "Error: 'node' command is not found, but 'nodejs' command is found. Your NodeJS should be too old." - exit 1 - fi - curlCheck=$(curl --version) - if [ "$curlCheck" == "" ]; then - "echo" "-e" "Installing Curl" - apt --yes install curl - fi - "echo" "-e" "Installing Node.js 18" - curl -sL https://deb.nodesource.com/setup_18.x | bash - >log.txt - apt --yes install nodejs - node -v - nodeCheckAgain=$(node -v) - if [ "$nodeCheckAgain" == "" ]; then - "echo" "-e" "Error during Node.js installation" - exit 1 - fi - fi - check=$(git --version) - if [ "$check" == "" ]; then - "echo" "-e" "Installing Git" - apt --yes install git - fi -} -if [ "$type" == "local" ]; then - defaultInstallPath="/opt/uptime-kuma" - if [ -e "/etc/redhat-release" ]; then - os=$("cat" "/etc/redhat-release") - distribution="rhel" - else - if [ -e "/etc/issue" ]; then - os=$(head -n1 /etc/issue | cut -f 1 -d ' ') - if [ "$os" == "Ubuntu" ]; then - distribution="ubuntu" - # Get ubuntu version - . /etc/lsb-release - version="$DISTRIB_RELEASE" - fi - if [ "$os" == "Debian" ]; then - distribution="debian" - fi - fi - fi - arch=$(uname -i) - "echo" "-e" "Your OS: ""$os" - "echo" "-e" "Distribution: ""$distribution" - "echo" "-e" "Version: ""$version" - "echo" "-e" "Arch: ""$arch" - if [ "$3" != "" ]; then - port="$3" - else - "read" "-p" "Listening Port [$defaultPort]: " "port" - if [ "$port" == "" ]; then - port="$defaultPort" - fi - fi - if [ "$2" != "" ]; then - installPath="$2" - else - "read" "-p" "Installation Path [$defaultInstallPath]: " "installPath" - if [ "$installPath" == "" ]; then - installPath="$defaultInstallPath" - fi - fi - # CentOS - if [ "$distribution" == "rhel" ]; then - nodeCheck=$(node -v) - if [ "$nodeCheck" != "" ]; then - "checkNode" - else - dnfCheck=$(dnf --version) - # Use yum - if [ "$dnfCheck" == "" ]; then - curlCheck=$(curl --version) - if [ "$curlCheck" == "" ]; then - "echo" "-e" "Installing Curl" - yum -y -q install curl - fi - "echo" "-e" "Installing Node.js 18" - curl -sL https://rpm.nodesource.com/setup_18.x | bash - >log.txt - yum install -y -q nodejs - else - curlCheck=$(curl --version) - if [ "$curlCheck" == "" ]; then - "echo" "-e" "Installing Curl" - dnf -y install curl - fi - "echo" "-e" "Installing Node.js 18" - curl -sL https://rpm.nodesource.com/setup_18.x | bash - >log.txt - dnf install -y nodejs - fi - node -v - nodeCheckAgain=$(node -v) - if [ "$nodeCheckAgain" == "" ]; then - "echo" "-e" "Error during Node.js installation" - exit 1 - fi - fi - check=$(git --version) - if [ "$check" == "" ]; then - "echo" "-e" "Installing Git" - yum -y -q install git - fi - # Ubuntu - else - if [ "$distribution" == "ubuntu" ]; then - "deb" - # Debian - else - if [ "$distribution" == "debian" ]; then - "deb" - else - # Unknown distribution - error=$((0)) - check=$(git --version) - if [ "$check" == "" ]; then - error=$((1)) - "echo" "-e" "Error: git is not found!" - "echo" "-e" "help: an installation guide is available at https://git-scm.com/book/en/v2/Getting-Started-Installing-Git" - fi - check=$(node -v) - if [ "$check" == "" ]; then - error=$((1)) - "echo" "-e" "Error: node is not found" - "echo" "-e" "help: an installation guide is available at https://nodejs.org/en/download" - fi - if [ $(($error > 0)) == 1 ]; then - "echo" "-e" "Please install above missing software" - exit 1 - fi - fi - fi - fi - check=$(pm2 --version) - if [ "$check" == "" ]; then - "echo" "-e" "Installing PM2" - npm install pm2 -g && pm2 install pm2-logrotate - pm2 startup - fi - # Check again - check=$(pm2 --version) - if [ "$check" == "" ]; then - "echo" "-e" "Error: pm2 is not found!" - "echo" "-e" "help: an installation guide is available at https://pm2.keymetrics.io/docs/usage/quick-start/" - exit 1 - fi - mkdir -p $installPath - cd $installPath - git clone https://github.com/louislam/uptime-kuma.git . - npm run setup - pm2 start server/server.js --name uptime-kuma -- --port=$port -else - defaultVolume="uptime-kuma" - check=$(docker -v) - if [ "$check" == "" ]; then - "echo" "-e" "Error: docker is not found!" - "echo" "-e" "help: an installation guide is available at https://docs.docker.com/desktop/" - exit 1 - fi - check=$(docker info) - if [[ "$check" == *"Is the docker daemon running"* ]]; then - "echo" "Error: docker is not running" - "echo" "help: a troubleshooting guide is available at https://docs.docker.com/config/daemon/troubleshoot/" - "exit" "1" - fi - if [ "$3" != "" ]; then - port="$3" - else - "read" "-p" "Expose Port [$defaultPort]: " "port" - if [ "$port" == "" ]; then - port="$defaultPort" - fi - fi - if [ "$2" != "" ]; then - volume="$2" - else - "read" "-p" "Volume Name [$defaultVolume]: " "volume" - if [ "$volume" == "" ]; then - volume="$defaultVolume" - fi - fi - "echo" "-e" "Port: $port" - "echo" "-e" "Volume: $volume" - docker volume create $volume - docker run -d --restart=always -p $port:3001 -v $volume:/app/data --name uptime-kuma louislam/uptime-kuma:1 -fi -"echo" "-e" "http://localhost:$port" From e5a20c995e6eedd410fe3c43b38362d55ea4b061 Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Wed, 20 Mar 2024 14:31:08 +0100 Subject: [PATCH 05/11] made sure to bump npm to the latest supported using node@18 --- .github/workflows/auto-test.yml | 4 ++-- README.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/auto-test.yml b/.github/workflows/auto-test.yml index 4804471fa5..10123e6a57 100644 --- a/.github/workflows/auto-test.yml +++ b/.github/workflows/auto-test.yml @@ -33,7 +33,7 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - - run: npm install npm@9 -g + - run: npm install npm@10 -g - run: npm install - run: npm run build - run: npm run test-backend @@ -61,7 +61,7 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - - run: npm install npm@9 -g + - run: npm install npm@10 -g - run: npm ci --production check-linters: diff --git a/README.md b/README.md index c8a0d24897..1791e27642 100644 --- a/README.md +++ b/README.md @@ -63,7 +63,7 @@ Requirements: ```bash # Update your npm -npm install npm@9 -g +npm install npm@10 -g git clone https://github.com/louislam/uptime-kuma.git cd uptime-kuma From dbf0303a9e480aee0e30c667267dbeac03d0154e Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Wed, 20 Mar 2024 14:31:26 +0100 Subject: [PATCH 06/11] Update CONTRIBUTING.md Co-authored-by: Adam Stachowicz --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9680728c7f..d1abc57fe3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -231,7 +231,7 @@ The goal is to make the Uptime Kuma installation as easy as installing a mobile ## Tools - [`Node.js`](https://nodejs.org/) >= 18 -- [`npm`](https://www.npmjs.com/) >= 8.5 +- [`npm`](https://www.npmjs.com/) >= 10.2.4 - [`git`](https://git-scm.com/) - IDE that supports [`ESLint`](https://eslint.org/) and EditorConfig (I am using [`IntelliJ IDEA`](https://www.jetbrains.com/idea/)) - A SQLite GUI tool (f.ex. [`SQLite Expert Personal`](https://www.sqliteexpert.com/download.html) or [`DBeaver Community`](https://dbeaver.io/download/)) From ab64696111a6ee243c7028e2cce3ff7843226fc4 Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Wed, 20 Mar 2024 14:31:31 +0100 Subject: [PATCH 07/11] Update README.md Co-authored-by: Adam Stachowicz --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 1791e27642..998c868288 100644 --- a/README.md +++ b/README.md @@ -57,7 +57,7 @@ Requirements: - ✅ Windows 10 (x64), Windows Server 2012 R2 (x64) or higher - ❌ Replit / Heroku - [Node.js](https://nodejs.org/en/download/) 18 / 20.4 -- [npm](https://docs.npmjs.com/cli/) 9 +- [npm](https://docs.npmjs.com/cli/) 10 - [Git](https://git-scm.com/downloads) - [pm2](https://pm2.keymetrics.io/) - For running Uptime Kuma in the background From 0a3ac1ffce0f9d4118ba954dcbb911b78dc1dc5a Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Wed, 20 Mar 2024 17:30:25 +0100 Subject: [PATCH 08/11] Update .github/workflows/auto-test.yml Co-authored-by: Adam Stachowicz --- .github/workflows/auto-test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/auto-test.yml b/.github/workflows/auto-test.yml index 10123e6a57..246a0beda6 100644 --- a/.github/workflows/auto-test.yml +++ b/.github/workflows/auto-test.yml @@ -61,6 +61,7 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} + check-latest: true - run: npm install npm@10 -g - run: npm ci --production From ddbdb9eb2eb2b81e7bb6e66081bab8d8945a38bc Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Wed, 20 Mar 2024 17:50:02 +0100 Subject: [PATCH 09/11] reverted bump to npm version --- .github/workflows/auto-test.yml | 2 +- CONTRIBUTING.md | 2 +- README.md | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/auto-test.yml b/.github/workflows/auto-test.yml index 246a0beda6..1cd5165c9e 100644 --- a/.github/workflows/auto-test.yml +++ b/.github/workflows/auto-test.yml @@ -62,7 +62,7 @@ jobs: with: node-version: ${{ matrix.node }} check-latest: true - - run: npm install npm@10 -g + - run: npm install npm@9 -g - run: npm ci --production check-linters: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d1abc57fe3..d9c0952cb4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -231,7 +231,7 @@ The goal is to make the Uptime Kuma installation as easy as installing a mobile ## Tools - [`Node.js`](https://nodejs.org/) >= 18 -- [`npm`](https://www.npmjs.com/) >= 10.2.4 +- [`npm`](https://www.npmjs.com/) >= 9.3 - [`git`](https://git-scm.com/) - IDE that supports [`ESLint`](https://eslint.org/) and EditorConfig (I am using [`IntelliJ IDEA`](https://www.jetbrains.com/idea/)) - A SQLite GUI tool (f.ex. [`SQLite Expert Personal`](https://www.sqliteexpert.com/download.html) or [`DBeaver Community`](https://dbeaver.io/download/)) diff --git a/README.md b/README.md index 998c868288..c8a0d24897 100644 --- a/README.md +++ b/README.md @@ -57,13 +57,13 @@ Requirements: - ✅ Windows 10 (x64), Windows Server 2012 R2 (x64) or higher - ❌ Replit / Heroku - [Node.js](https://nodejs.org/en/download/) 18 / 20.4 -- [npm](https://docs.npmjs.com/cli/) 10 +- [npm](https://docs.npmjs.com/cli/) 9 - [Git](https://git-scm.com/downloads) - [pm2](https://pm2.keymetrics.io/) - For running Uptime Kuma in the background ```bash # Update your npm -npm install npm@10 -g +npm install npm@9 -g git clone https://github.com/louislam/uptime-kuma.git cd uptime-kuma From 8b3a6f6159ab29c8d7c6b5d3b3f58e9c18b29330 Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Wed, 20 Mar 2024 17:50:39 +0100 Subject: [PATCH 10/11] reverted a npm version bump missed in the last revert --- .github/workflows/auto-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/auto-test.yml b/.github/workflows/auto-test.yml index 1cd5165c9e..8881ffbcdd 100644 --- a/.github/workflows/auto-test.yml +++ b/.github/workflows/auto-test.yml @@ -33,7 +33,7 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - - run: npm install npm@10 -g + - run: npm install npm@9 -g - run: npm install - run: npm run build - run: npm run test-backend From 5ac8cc468913542b0e991beb404dbc1aeaf24064 Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Wed, 27 Mar 2024 18:06:42 +0100 Subject: [PATCH 11/11] removed the `npm@9` installation --- .github/workflows/auto-test.yml | 3 --- README.md | 3 --- 2 files changed, 6 deletions(-) diff --git a/.github/workflows/auto-test.yml b/.github/workflows/auto-test.yml index 8881ffbcdd..c791bc8803 100644 --- a/.github/workflows/auto-test.yml +++ b/.github/workflows/auto-test.yml @@ -33,7 +33,6 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - - run: npm install npm@9 -g - run: npm install - run: npm run build - run: npm run test-backend @@ -61,8 +60,6 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - check-latest: true - - run: npm install npm@9 -g - run: npm ci --production check-linters: diff --git a/README.md b/README.md index c8a0d24897..0459692ae0 100644 --- a/README.md +++ b/README.md @@ -62,9 +62,6 @@ Requirements: - [pm2](https://pm2.keymetrics.io/) - For running Uptime Kuma in the background ```bash -# Update your npm -npm install npm@9 -g - git clone https://github.com/louislam/uptime-kuma.git cd uptime-kuma npm run setup