Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address the hardcoded number of commands #4

Open
shanereetz opened this issue Feb 9, 2024 · 0 comments
Open

Address the hardcoded number of commands #4

shanereetz opened this issue Feb 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@shanereetz
Copy link
Member

In several places in the original code, the magic value "19" was referenced as a loop iterator.
It's unclear if this was to limit work done per cycle, or commands that could be in a group.

I moved this to a value into a constant "maxRelatedGroups : USINT := 19; // TODO evaluate this" in PLCOpenCommand.

To address this issue, either more context could be added to the comment noted above, or perhaps the value should be increased, or something else.

@shanereetz shanereetz added the enhancement New feature or request label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant