You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In several places in the original code, the magic value "19" was referenced as a loop iterator.
It's unclear if this was to limit work done per cycle, or commands that could be in a group.
I moved this to a value into a constant "maxRelatedGroups : USINT := 19; // TODO evaluate this" in PLCOpenCommand.
To address this issue, either more context could be added to the comment noted above, or perhaps the value should be increased, or something else.
The text was updated successfully, but these errors were encountered:
In several places in the original code, the magic value "19" was referenced as a loop iterator.
It's unclear if this was to limit work done per cycle, or commands that could be in a group.
I moved this to a value into a constant "maxRelatedGroups : USINT := 19; // TODO evaluate this" in PLCOpenCommand.
To address this issue, either more context could be added to the comment noted above, or perhaps the value should be increased, or something else.
The text was updated successfully, but these errors were encountered: