Merge pull request #6 from TrekkieCoder/main

Better error and log handling

Author: TrekkieCoder

managers/ingress.go

@@ -67,7 +67,7 @@ func (r *LoxilbIngressReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 	// when ingress is added, install rule to loxilb-ingress
 	models, err := r.createLoxiModelList(ctx, ingress)
 	if err != nil {
-		logger.Info("failed to create loxilb loadbalancer model", "error", err)
+		logger.Error(err, "Failed to set ingress. failed to create loxilb loadbalancer model", "[]loxiapi.LoadBalancerModel", models)
 		return ctrl.Result{}, err
 	}
 
@@ -209,7 +209,7 @@ func (r *LoxilbIngressReconciler) updateIngressStatus(ctx context.Context, ingre
 		if lbName, isok := ingress.Annotations["loadbalancer-service"]; isok {
 			lbSvcKey.Name = lbName
 		} else {
-			return fmt.Errorf("ingress %s/%s has no information about loadbalancer service", ingress.Namespace, ingress.Name)
+			return nil
 		}
 	}
 

pkg/loxilb.go

@@ -31,6 +31,7 @@ func SpawnLoxiLB() {
 	for {
 		cmd := exec.Command(LoxiLBImg, "--proxyonlymode")
 		klog.Infof("Spawning loxilb: %s", cmd)
+		cmd.Stdout = os.Stdout
 		err := cmd.Run()
 		if err != nil {
 			klog.Infof("Spawning loxilb failed: %s", err)