Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package refactoring - general chess-independent notions #292

Closed
lrozenblyum opened this issue Feb 7, 2019 · 0 comments · Fixed by #357
Closed

Package refactoring - general chess-independent notions #292

lrozenblyum opened this issue Feb 7, 2019 · 0 comments · Fixed by #357
Assignees
@lrozenblyum
Labels
maintainability
Milestone
0.6

Comments

@lrozenblyum
Copy link
Owner

During #235 some chess independent notions have been created.
The examples are:
NormalizedBrain, GameState, GameTransition, GenericBrain.

The idea is to refactor the whole package structure completely:
.game.common <-- chess independent stuff
.game.chess

It might be good to implement in the same release as #268 since both ideas involve package refactorings.
It might be a good step of preparation to #118
@lrozenblyum lrozenblyum added this to the 0.5 milestone Feb 7, 2019
@lrozenblyum lrozenblyum modified the milestones: 0.5, 0.6 Feb 14, 2019
@lrozenblyum lrozenblyum mentioned this issue Aug 21, 2019
Closed
@lrozenblyum lrozenblyum self-assigned this Sep 11, 2019
@lrozenblyum lrozenblyum pinned this issue Sep 11, 2019
lrozenblyum added a commit that referenced this issue Sep 12, 2019
@lrozenblyum
GroupId renamed.
bb16a84 
It's a preparation to #184
It's good to do before #292
(since we're going to introduce some common game notions)
It may prepare us to #118
@lrozenblyum lrozenblyum mentioned this issue Sep 12, 2019
Merged
@lrozenblyum lrozenblyum mentioned this issue Sep 24, 2019
Merged
@lrozenblyum lrozenblyum unpinned this issue Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrozenblyum lrozenblyum

Labels
maintainability
Projects
None yet
Milestone
0.6
1 participant
@lrozenblyum