Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Position.hasCastlingExecuted #321

Open
lrozenblyum opened this issue Jul 2, 2019 · 0 comments
Open

Remove Position.hasCastlingExecuted #321

lrozenblyum opened this issue Jul 2, 2019 · 0 comments
Labels
core LegalPlayer, Position and related evaluation maintainability

Comments

@lrozenblyum
Copy link
Owner

This flag was added during #293 in order to make CastlingSafety work correctly.
However it's not needed in Position class logic itself.
Such historical information may be kept by storing reference of Position to Position (and/or maybe Move history).

This historical overview may be also needed during #158 #155 so this task may be done in combination with one of them.

@lrozenblyum lrozenblyum added evaluation maintainability core LegalPlayer, Position and related labels Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core LegalPlayer, Position and related evaluation maintainability
Projects
None yet
Development

No branches or pull requests

1 participant