Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winboard player construction - simplify #334

Closed
lrozenblyum opened this issue Aug 15, 2019 · 0 comments · Fixed by #355
Closed

Winboard player construction - simplify #334

lrozenblyum opened this issue Aug 15, 2019 · 0 comments · Fixed by #355
Assignees
Milestone

Comments

@lrozenblyum
Copy link
Owner

During implementation of #278 it has become obvious that winboard player creation via static 'factory' method looks out-of-common style. It is also against OOP principles.
We should allow WinboardPlayer creation via poor constructor.

Risks:
a) 'singleton' enforcement won't be as easy (although we don't have it right now)
b) some tests which were depending on our 2-phase construction of the player (with separate initCommander call) may behave differently and not test well what's needed. Requires good investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant