Skip to content

Commit 3da1504

Browse files
committed
Resolves #55: added missing strings for notification settings
1 parent 5a185d5 commit 3da1504

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

feature/push/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/push/ui/PushNotificationSettingCategoriesListUi.kt

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ private fun getLocalizedNotificationGroupName(groupName: String): String {
187187
"course-wide-discussion" -> R.string.push_notification_settings_group_courseWideDiscussionNotifications
188188
"tutor-notification" -> R.string.push_notification_settings_group_tutorNotifications
189189
"editor-notification" -> R.string.push_notification_settings_group_editorNotifications
190+
"exam-notification" -> R.string.push_notification_settings_group_examNotifications
190191
"instructor-notification" -> R.string.push_notification_settings_group_instructorNotifications
191192
"user-notification" -> R.string.push_notification_settings_group_conversationNotification
192193
else -> null
@@ -213,12 +214,17 @@ private fun getLocalizedNotificationSettingName(settingName: String): String {
213214
"course-and-exam-archiving-started" -> R.string.push_notification_settings_setting_courseAndExamArchivingStarted
214215
"file-submission-successful" -> R.string.push_notification_settings_setting_fileSubmissionSuccessful
215216
"programming-test-cases-changed" -> R.string.push_notification_settings_setting_programmingTestCasesChanged
217+
"new-reply-for-exam-post" -> R.string.push_notification_settings_setting_newExamReply
218+
"new-exam-post" -> R.string.push_notification_settings_setting_newExamPost
216219
"tutorial-group-registration" -> R.string.push_notification_settings_setting_registrationTutorialGroup
217220
"tutorial-group-delete-update" -> R.string.push_notification_settings_setting_tutorialGroupUpdateDelete
218221
"tutorial-group-assign-unassign" -> R.string.push_notification_settings_setting_assignUnassignTutorialGroup
219222
"quiz_start_reminder" -> R.string.push_notification_settings_setting_quizStartReminder
220223
"conversation-message" -> R.string.push_notification_setting_setting_newConversationMessages
221224
"new-reply-in-conversation" -> R.string.push_notification_setting_setting_newConversationReplies
225+
"user-mention" -> R.string.push_notification_setting_setting_conversationUserMention
226+
"data-export-failed" -> R.string.push_notification_setting_setting_conversationDataExportFailed
227+
"data-export-created" -> R.string.push_notification_setting_setting_conversationDataExportCreated
222228
else -> null
223229
}
224230

@@ -243,10 +249,15 @@ private fun getLocalizedNotificationSettingDescription(settingName: String): Str
243249
"course-and-exam-archiving-started" -> R.string.push_notification_setting_setting_description_courseAndExamArchivingStartedDescription
244250
"file-submission-successful" -> R.string.push_notification_setting_setting_description_fileSubmissionSuccessfulDescription
245251
"programming-test-cases-changed" -> R.string.push_notification_setting_setting_description_programmingTestCasesChangedDescription
252+
"new-reply-for-exam-post" -> R.string.push_notification_settings_setting_newExamReplyDescription
253+
"new-exam-post" -> R.string.push_notification_settings_setting_newExamPostDescription
246254
"tutorial-group-registration" -> R.string.push_notification_setting_setting_description_registrationTutorialGroupStudentDescription
247255
"tutorial-group-delete-update" -> R.string.push_notification_setting_setting_description_tutorialGroupUpdateDeleteDescription
248256
"tutorial-group-assign-unassign" -> R.string.push_notification_setting_setting_description_assignUnassignTutorialGroupDescription
249257
"quiz_start_reminder" -> R.string.push_notification_setting_setting_description_quizStartReminder
258+
"user-mention" -> R.string.push_notification_settings_setting_conversationUserMentionDescription
259+
"new-reply-in-conversation" -> R.string.push_notification_setting_setting_newConversationRepliesDescription
260+
"conversation-message" -> R.string.push_notification_setting_setting_newConversationMessagesDescription
250261
else -> null
251262
}
252263

feature/push/src/main/res/values/push_notification_settings_strings.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
<string name="push_notification_settings_group_courseWideDiscussionNotifications">Course-wide Discussion Notifications</string>
2222
<string name="push_notification_settings_group_tutorNotifications">Tutor Notifications</string>
2323
<string name="push_notification_settings_group_editorNotifications">Editor Notifications</string>
24+
<string name="push_notification_settings_group_examNotifications">Exam Notifications</string>
2425
<string name="push_notification_settings_group_instructorNotifications">Instructor Notifications</string>
2526
<string name="push_notification_settings_group_conversationNotification">Conversation Notifications</string>
2627

@@ -37,6 +38,8 @@
3738
<string name="push_notification_settings_setting_newCoursePost">New Course Post</string>
3839
<string name="push_notification_settings_setting_newReplyForCoursePost">New Reply for Course Post</string>
3940
<string name="push_notification_settings_setting_newAnnouncementPost">New Announcement</string>
41+
<string name="push_notification_settings_setting_newExamPost">New Exam Post</string>
42+
<string name="push_notification_settings_setting_newExamReply">New Reply for Exam Post</string>
4043
<string name="push_notification_settings_setting_courseAndExamArchivingStarted">Course &amp; Exam Archiving Started</string>
4144
<string name="push_notification_settings_setting_fileSubmissionSuccessful">File Submission Successful</string>
4245
<string name="push_notification_settings_setting_programmingTestCasesChanged">Changed Test Cases for Programming Exercises</string>
@@ -46,6 +49,9 @@
4649
<string name="push_notification_settings_setting_quizStartReminder">Quiz start</string>
4750
<string name="push_notification_setting_setting_newConversationMessages">New messages in conversations</string>
4851
<string name="push_notification_setting_setting_newConversationReplies">New replies in conversations</string>
52+
<string name="push_notification_setting_setting_conversationUserMention">New user mention in conversations</string>
53+
<string name="push_notification_setting_setting_conversationDataExportFailed">Data Export has failed</string>
54+
<string name="push_notification_setting_setting_conversationDataExportCreated">Data Export has been created</string>
4955

5056
<string name="push_notification_setting_setting_description_basicWeeklySummaryDescription">Receive a basic weekly summary every Friday at 5pm (e.g. what new exercises have been released this week and are still open)"</string>
5157
<string name="push_notification_setting_setting_description_exerciseReleasedDescription">Get notified when a new exercise has been released"</string>
@@ -59,6 +65,8 @@
5965
<string name="push_notification_setting_setting_description_newCoursePostDescription">Receive a notification when a new course-wide post has been created"</string>
6066
<string name="push_notification_setting_setting_description_newReplyForCoursePostDescription">Receive a notification when a new reply for a course-wide post has been created"</string>
6167
<string name="push_notification_setting_setting_description_newAnnouncementPostDescription">Receive a notification when a new announcement has been created"</string>
68+
<string name="push_notification_settings_setting_newExamPostDescription">Get notified when a new exam post has been created</string>
69+
<string name="push_notification_settings_setting_newExamReplyDescription">Get notified when a new reply for an exam post has been created</string>
6270
<string name="push_notification_setting_setting_description_courseAndExamArchivingStartedDescription">Receive a notification when the process of archiving a course or exam has been started"</string>
6371
<string name="push_notification_setting_setting_description_fileSubmissionSuccessfulDescription">Receive a notification after you successfully submitted a file upload exercise"</string>
6472
<string name="push_notification_setting_setting_description_programmingTestCasesChangedDescription">Get notified if test cases for a programming exercises have been changed"</string>
@@ -67,6 +75,10 @@
6775
<string name="push_notification_setting_setting_description_tutorialGroupUpdateDeleteDescription">Get notified when a tutorial group for which you are registered or a tutor was updated or deleted"</string>
6876
<string name="push_notification_setting_setting_description_assignUnassignTutorialGroupDescription">Get notified when you were assigned or unassigned to lead a tutorial group"</string>
6977
<string name="push_notification_setting_setting_description_quizStartReminder">Get notified when a quiz has just started or if a quiz is about to start.</string>
78+
<string name="push_notification_settings_setting_conversationUserMentionDescription">Receive a notification when you are mentioned in a message or reply</string>
79+
<string name="push_notification_setting_setting_newConversationRepliesDescription">Get notified when a new reply for a message has been created</string>
80+
<string name="push_notification_setting_setting_newConversationMessagesDescription">Receive a notification when a new message has been created</string>
81+
7082

7183
<string name="push_notification_settings_sync_dialog_title">Syncing</string>
7284
<string name="push_notification_settings_sync_dialog_message">Uploading settings to server…</string>

0 commit comments

Comments
 (0)