Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role icon changes to student when reacting on post in thread #235

Open
julian-wls opened this issue Dec 17, 2024 · 2 comments · Fixed by #266
Open

Role icon changes to student when reacting on post in thread #235

julian-wls opened this issue Dec 17, 2024 · 2 comments · Fixed by #266
Assignees
Labels
bug Something isn't working

Comments

@julian-wls
Copy link
Contributor

Describe the bug

When adding a reaction in the thread view (parent post or answer post) the role icons change to student.

To Reproduce
Steps to reproduce the behavior:

  1. Click on any post in the chat to open the thread view
  2. React on it in the thread view
  3. See the role icons change

Expected behavior
The role icons should not change.

Screenrecording

Screen_recording_20241217_132041.webm

Additional context

This bug was discovered while working on #228, but affects develop, too.

@julian-wls julian-wls added the bug Something isn't working label Dec 17, 2024
@anian03
Copy link
Member

anian03 commented Dec 25, 2024

Would assume this is caused by the websocket not sending the user roles when a message is updated like that. Seems like you have "student" as the fallback. On iOS (and as far as I know the web app too) this is "fixed" by keeping the old user role value

@julian-wls julian-wls self-assigned this Jan 3, 2025
@julian-wls
Copy link
Contributor Author

Would assume this is caused by the websocket not sending the user roles when a message is updated like that. Seems like you have "student" as the fallback. On iOS (and as far as I know the web app too) this is "fixed" by keeping the old user role value

Thanks for the hint. I'll take a look at it and try to not update the role when the message gets updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants